Updated subscriptions methods to use cursor pagination #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized there is already a pull request on this subject that dealt with the change more holistically. This commit did however get me over the obstacle I was facing. |
|
@jonjarvis thanks for the contribution. As you noted, this is a subset of #614. I'd rather see the holistic implementation get merged. I'll try to see if we can lift the blocker there. |
|
Closing pull request because #614 is a more holistic solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the three subscription methods to use the recommended cursor pagination in the request instead of the default offset pagination (which has a 100 page limit).
https://developer.zendesk.com/api-reference/help_center/help-center-api/content_subscriptions/#list-section-subscriptions