Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,3 @@ updates:
# Add reviewer
reviewers:
- "approvers"

2 changes: 1 addition & 1 deletion .github/workflows/readme.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ jobs:
uses: clouddrove/github-shared-workflows/.github/workflows/readme.yml@master
secrets:
TOKEN : ${{ secrets.GITHUB }}
SLACK_WEBHOOK_TERRAFORM: ${{ secrets.SLACK_WEBHOOK_TERRAFORM }}
SLACK_WEBHOOK_TERRAFORM: ${{ secrets.SLACK_WEBHOOK_TERRAFORM }}
1 change: 0 additions & 1 deletion .github/workflows/tf-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@ jobs:
uses: clouddrove/github-shared-workflows/.github/workflows/tf-checks.yml@master
with:
working_directory: './examples/'

4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ override.tf.json




# ignored files
*.tfstate
*.tfstate.backup
.terraform
.idea
*.iml
*.terraform.lock.hcl
*.terraform.lock.hcl
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
repos:

- repo: https://github.com/gruntwork-io/pre-commit
rev: v0.1.12 # Get the latest from: https://github.com/gruntwork-io/pre-commit/releases
rev: v0.1.23 # Get the latest from: https://github.com/gruntwork-io/pre-commit/releases
hooks:
- id: terraform-fmt
- id: shellcheck
- id: tflint

- repo: git://github.com/pre-commit/pre-commit-hooks
rev: v4.0.1 # Use the ref you want to point at
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v5.0.0 # Use the ref you want to point at
hooks:
- id: end-of-file-fixer
- id: trailing-whitespace
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[0.15.0]: https://github.com/clouddrove/terraform-aws-security-hub/compare/0.15.0...master
[1.0.1]: https://github.com/clouddrove/terraform-aws-security-hub/releases/tag/1.0.1

[1.0.2]: https://github.com/clouddrove/terraform-aws-security-hub/compare/1.0.1...1.0.2
[1.0.2]: https://github.com/clouddrove/terraform-aws-security-hub/compare/1.0.1...1.0.2
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -198,4 +198,4 @@
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
limitations under the License.
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<hr>


We are a group of DevOps engineers & architects, joining hands in this ever evolving digital landscape. With our strong belief in Automation; just like microservices, always on the lookout to split the the infrastructure into smaller connected resources (database, cluster and more) which could be standardized, are manageable, scalable, secure & follow industry best practices.
We are a group of DevOps engineers & architects, joining hands in this ever evolving digital landscape. With our strong belief in Automation; just like microservices, always on the lookout to split the the infrastructure into smaller connected resources (database, cluster and more) which could be standardized, are manageable, scalable, secure & follow industry best practices.


This module includes Terraform open source, examples, and automation tests (for better understanding), which would help you create and improve your infrastructure with minimalistic coding.
Expand Down Expand Up @@ -79,7 +79,7 @@ This table contains both Prerequisites and Providers:
Refer to complete documentation: [here](docs/io.md)


<!--
<!--
## Module Dependencies

This module has dependencies on:
Expand All @@ -102,7 +102,7 @@ Refer [here](CHANGELOG.md).

## ✨ Contributors

Big thanks to our contributors for elevating our project with their dedication and expertise! But, we do not wish to stop there, would like to invite contributions from the community in improving these projects and making them more versatile for better reach. Remember, every bit of contribution is immensely valuable, as, together, we are moving in only 1 direction, i.e. forward.
Big thanks to our contributors for elevating our project with their dedication and expertise! But, we do not wish to stop there, would like to invite contributions from the community in improving these projects and making them more versatile for better reach. Remember, every bit of contribution is immensely valuable, as, together, we are moving in only 1 direction, i.e. forward.

<a href="https://github.com/clouddrove/terraform-aws-security-hub/graphs/contributors">
<img src="https://contrib.rocks/image?repo=clouddrove/terraform-aws-security-hub&max" />
Expand Down Expand Up @@ -130,7 +130,7 @@ Big thanks to our contributors for elevating our project with their dedication a



## Feedback
## Feedback
Spot a bug or have thoughts to share with us? Let's squash it together! Log it in our [issue tracker](https://github.com/clouddrove/terraform-aws-security-hub/issues), feel free to drop us an email at [[email protected]](mailto:[email protected]).

Show some love with a ★ on [our GitHub](https://github.com/clouddrove/terraform-aws-security-hub)! if our work has brightened your day! – your feedback fuels our journey!
Expand All @@ -142,7 +142,7 @@ We have [*100+ Terraform modules*][terraform_modules] 🙌. You could consider t

- [Terraform Module Registry:](https://registry.terraform.io/namespaces/clouddrove) Discover our Terraform modules here.

- [Terraform Modules for AWS/Azure Modules:](https://github.com/clouddrove/toc) Explore our comprehensive Table of Contents for easy navigation through our documentation for modules pertaining to AWS, Azure & GCP.
- [Terraform Modules for AWS/Azure Modules:](https://github.com/clouddrove/toc) Explore our comprehensive Table of Contents for easy navigation through our documentation for modules pertaining to AWS, Azure & GCP.

- [Terraform Modules for Digital Ocean:](https://github.com/terraform-do-modules/toc) Check out our specialized Terraform modules for Digital Ocean.

Expand All @@ -168,7 +168,7 @@ Join our tech elites [Join Now][slack] 🚀
Click [here][blog] :books: :star2:

## Tap into our capabilities
We provide a platform for organizations to engage with experienced top-tier DevOps & Cloud services. Tap into our pool of certified engineers and architects to elevate your DevOps and Cloud Solutions.
We provide a platform for organizations to engage with experienced top-tier DevOps & Cloud services. Tap into our pool of certified engineers and architects to elevate your DevOps and Cloud Solutions.

At [CloudDrove][website], has extensive experience in designing, building & migrating environments, securing, consulting, monitoring, optimizing, automating, and maintaining complex and large modern systems. With remarkable client footprints in American & European corridors, our certified architects & engineers are ready to serve you as per your requirements & schedule. Write to us at [[email protected]](mailto:[email protected]).

Expand Down
6 changes: 3 additions & 3 deletions README.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ usage: |-
member_account_id = "123344847783"
member_mail_id = "[email protected]"

#standards
#standards
enabled_standards = [
"standards/aws-foundational-security-best-practices/v/1.0.0",
"ruleset/cis-aws-foundations-benchmark/v/1.2.0"
Expand All @@ -74,5 +74,5 @@ usage: |-
"product/aws/macie"
]
}
```

```
1 change: 0 additions & 1 deletion docs/io.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@
| Name | Description |
|------|-------------|
| id | The ID of the secuirty hub. |

4 changes: 2 additions & 2 deletions examples/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module "security-hub" {
}
]

#standards
#standards
enabled_standards = [
"standards/aws-foundational-security-best-practices/v/1.0.0",
"ruleset/cis-aws-foundations-benchmark/v/1.2.0"
Expand All @@ -34,4 +34,4 @@ module "security-hub" {
"product/aws/inspector",
"product/aws/macie"
]
}
}
1 change: 0 additions & 1 deletion examples/outputs.tf
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#Module : Security-hub
#Description : Terraform module to securitry hub outputs.
output "id" {
value = module.security-hub.*.id

Check warning on line 4 in examples/outputs.tf

View workflow job for this annotation

GitHub Actions / tf-lint / tflint

List items should be accessed using square brackets
description = "The ID of the secuirty hub."
}

2 changes: 1 addition & 1 deletion examples/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ terraform {
version = ">= 5.31.0"
}
}
}
}
2 changes: 1 addition & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ resource "aws_securityhub_product_subscription" "products" {
product_arn = each.key
}

# To enable add member account to security-hub.
# To enable add member account to security-hub.
resource "aws_securityhub_member" "example" {
for_each = { for member in var.member_details : member.account_id => member }
account_id = each.value.account_id
Expand Down
1 change: 0 additions & 1 deletion outputs.tf
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#Module : Security-hub
#Description : Terraform module to securitry hub outputs.
output "id" {
value = join("", aws_securityhub_account.security_hub.*.id)

Check warning on line 4 in outputs.tf

View workflow job for this annotation

GitHub Actions / tf-lint / tflint

List items should be accessed using square brackets
description = "The ID of the secuirty hub."
}

18 changes: 9 additions & 9 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@

variable "control_finding_generator" {
description = <<-DOC
Updates whether the calling account has consolidated control findings turned on.
If the value for this field is set to SECURITY_CONTROL,
Security Hub generates a single finding for a control check even when the check applies to multiple enabled standards.
If the value for this field is set to STANDARD_CONTROL,
Security Hub generates separate findings for a control check when the check applies to multiple enabled standards.
For accounts that are part of an organization,
Updates whether the calling account has consolidated control findings turned on.
If the value for this field is set to SECURITY_CONTROL,
Security Hub generates a single finding for a control check even when the check applies to multiple enabled standards.
If the value for this field is set to STANDARD_CONTROL,
Security Hub generates separate findings for a control check when the check applies to multiple enabled standards.
For accounts that are part of an organization,
this value can only be updated in the administrator account.
DOC
type = string
Expand All @@ -20,8 +20,8 @@

variable "auto_enable_controls" {
description = <<-DOC
Whether to automatically enable new controls when they are added to standards that are enabled.
By default, this is set to true, and new controls are enabled automatically.
Whether to automatically enable new controls when they are added to standards that are enabled.
By default, this is set to true, and new controls are enabled automatically.
To not automatically enable new controls, set this to false.
DOC
type = bool
Expand Down Expand Up @@ -71,7 +71,7 @@
description = "Set to false to prevent the module from creating any resources."
}

variable "name" {

Check warning on line 74 in variables.tf

View workflow job for this annotation

GitHub Actions / tf-lint / tflint

variable "name" is declared but not used
type = string
default = ""
}
}
2 changes: 1 addition & 1 deletion versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ terraform {
version = ">= 5.31.0"
}
}
}
}