add buffer.transcode to nodejs_compat #2462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/buffer-transcode
branch
from
eb1d55e to
935fe01
Compare
jasnell
reviewed
Jul 30, 2024
jasnell
reviewed
Jul 30, 2024
jasnell
reviewed
Jul 30, 2024
jasnell
reviewed
Jul 30, 2024
anonrig
force-pushed
the
yagiz/buffer-transcode
branch
from
935fe01 to
f6063e3
Compare
jasnell
reviewed
Jul 30, 2024
jasnell
reviewed
Jul 30, 2024
jasnell
reviewed
Jul 30, 2024
jasnell
reviewed
Jul 30, 2024
jasnell
reviewed
Jul 30, 2024
jasnell
reviewed
Jul 30, 2024
jasnell
reviewed
Jul 30, 2024
anonrig
force-pushed
the
yagiz/buffer-transcode
branch
6 times, most recently
from
1299807 to
f171dbd
Compare
jasnell
reviewed
Jul 31, 2024
jasnell
reviewed
Jul 31, 2024
jasnell
reviewed
Jul 31, 2024
jasnell
reviewed
Jul 31, 2024
jasnell
reviewed
Jul 31, 2024
anonrig
force-pushed
the
yagiz/buffer-transcode
branch
2 times, most recently
from
f4a7d0c to
928e981
Compare
jasnell
previously approved these changes
Aug 1, 2024
danlapid
reviewed
Aug 1, 2024
danlapid
reviewed
Aug 1, 2024
danlapid
reviewed
Aug 1, 2024
danlapid
reviewed
Aug 1, 2024
danlapid
reviewed
Aug 1, 2024
danlapid
reviewed
Aug 1, 2024
danlapid
reviewed
Aug 1, 2024
danlapid
reviewed
Aug 1, 2024
danlapid
reviewed
Aug 1, 2024
anonrig
force-pushed
the
yagiz/buffer-transcode
branch
from
928e981 to
d282e23
Compare
danlapid
approved these changes
Aug 1, 2024
anonrig
force-pushed
the
yagiz/buffer-transcode
branch
from
d282e23 to
4217fe5
Compare
|
Adding the "needs-internal-pr" label on this to ensure that we make certain that the internal CI run is green before this lands. Once the internal CI comes back green with this change, the label can be removed and the PR can be merged |
jasnell
approved these changes
Aug 1, 2024
anonrig
force-pushed
the
yagiz/buffer-transcode
branch
from
4217fe5 to
9e26f4e
Compare
anonrig
force-pushed
the
yagiz/buffer-transcode
branch
from
9e26f4e to
95838ff
Compare
|
Internal PR is now resolved. We can merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request adds
require('node:buffer').transcode()support. It uses ICU for most encodings, and simdutf for latin1, utf8 and utf-16 operations.