Make consulTTL value configurable #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark DeLillo <[email protected]>
|
Hey mdelillo! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
@SocalNick We determined that the optimal value for the TTL to support a fully-colocated deployment is 20s. Would you like us to submit new PRs that change the values to that, instead of making it configurable? |
Contributor
|
@sclevine new hardcoded default is fine by me as long as there aren't any negative side effects. |
Contributor
Author
|
@SocalNick related discussion for the equivalent Diego PRs: cloudfoundry/diego-release#204 |
capi-bot
added a commit
that referenced
this pull request
May 29, 2018
Bump src/cloud_controller_ng
Tim Downey:
Fix manifest route ordering issues in spec
Jeff Pak:
do not crash the deployment updater when diego's unavailable
Bump src/code.cloudfoundry.org/bbs
Stephane Jolicoeur:
ActualLRPGroup.Resolve now returns an error rather than panicking
Eric Malm:
Merge pull request #29 from dtimm/patch-1
David Timm:
fix typo
capi-bot
added a commit
that referenced
this pull request
Jul 7, 2023
Bump src/code.cloudfoundry.org/tps
M. Oleske:
add github actions dependabot bumping (#29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with all the diego components behaving this way, the consul in PCF Dev gets overloaded and goes unresponsive.
PCF Dev needs this value to be increased/configurable.
This became necessary when these services switch from using
dns_health_checkto the TTL method. When thedns_health_checkdoes not succeed within the TTL, consul will still respond to DNS queries for that service. Using the new TTL method, consul will unregister the service from it's DNS registry if it fails to update it's healthcheck status within the TTL.This depends on:
cloudfoundry/cc-uploader#1
cloudfoundry-attic/nsync#12
cloudfoundry-attic/cloud-controller-stager#13
cloudfoundry/tps#7
Signed-off-by: Anthony Emengo [email protected]
Signed-off-by: Mark DeLillo [email protected]
masterbranch