Add Azure Storage CLI connection config to specs and yml.erb files #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathap
force-pushed
the
azure-storage-cli-connection-config
branch
from
45491ee to
6571de4
Compare
13 tasks
- Add four job templates to api, worker, and clock to emit storage-cli JSON: storage_cli_config_droplets.json.erb storage_cli_config_packages.json.erb storage_cli_config_buildpacks.json.erb storage_cli_config_resource_pool.json.erb Each template builds "connection_config" for AzureRM only, applies a default put_timeout_in_seconds: "41" if missing, and passes through any custom flags. - Expose new config paths in cloud_controller_*/*.yml.erb - Register the new files in job specs so they render under config/
kathap
force-pushed
the
azure-storage-cli-connection-config
branch
from
6651acf to
ac99f38
Compare
5 tasks
kathap
force-pushed
the
azure-storage-cli-connection-config
branch
2 times, most recently
from
f4e7f8a to
3b8be47
Compare
kathap
force-pushed
the
azure-storage-cli-connection-config
branch
from
3b8be47 to
0c12f66
Compare
jochenehret
reviewed
Oct 6, 2025
There was a problem hiding this comment.
This is a lot of duplicated code. Can you try to move the common coding to the shared_job_templates folder? I'm not 100% sure if that works, but there should be an option to move common .erb coding to a shared file.
There was a problem hiding this comment.
Could be that it is not so trivial/possible: BOSH renders .erb on the director/agent before the VM’s job tree exists. At this moment, paths like /var/vcap/jobs/cloud_controller_ do not exist. There’s no supported way to “reach over” to shared_job_templates in the repo during render.
…ds is not set, return nil
Co-Authored-By: johha <[email protected]>
kathap
force-pushed
the
azure-storage-cli-connection-config
branch
3 times, most recently
from
82a2ad2 to
b68bb41
Compare
…t, CCNG reads provider from JSON
kathap
force-pushed
the
azure-storage-cli-connection-config
branch
from
b68bb41 to
d7b2b39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Add Azure Storage CLI connection configuration property to the Cloud Controller specs for bosh-azure-storage-cli based blobstore client integration
An explanation of the use cases your change solves
bosh-azure-storage-cli based blobstore client is a potential replacement for deprecated fog libraries like azure fog
Links to any other associated PRs
Extend bosh-azure-storage-cli: new blob commands + upload timeout bosh-azure-storage-cli#22
ADR: Use Bosh Storage CLIs for Blobstore Operations cloud_controller_ng#4443
POC: bosh-azure-storage-cli based blobstore client cloud_controller_ng#4397
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite