Add SAN to cc_tls certificate #903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this change about?
We need to add a SAN to the
cc_tlscert. This is so we can safely upgrade to Go 1.15 incapi-release. Without this, the cc_uploader will complain in Go 1.15 that CC's cert relies on the deprecated pattern of specifying a common name without a SAN.What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...
This change allows
capi-releasedevelopers to continue to auto-bump their Go dependency to 1.15+ (currently it is pinned at 1.14.x). Ifcapi-releasebumps Go without this change, the cc_uploader will fail to talk to CC, andcf pushes will fail at the staging step (affecting Codys).Please provide any contextual information.
Has a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
Please see this Slack thread. This PR on its own is not a breaking change. However, the bump to go 1.15 which this is in preparation for will cause a breaking change to
cf push. We would like to use this PR to open a conversation about potential next steps:a) Generate certificate property as-is and ask operators to delete the variable
cc_tlsprior to deploying so that the cert will be re-generated.b) Add
update_mode: convergeto thecc_tlsproperty to ensure the cert will be re-generated. (Potentially remove it in a future release).Regardless of which mitigation we introduce, we may want to save the GoLang 1.15 upgrade to the next minor version.
How should this change be described in cf-deployment release notes?
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
This is the simplest varification but you can also provide additional commands to test that the variable holds the desired value.
bosh ssh apisudo suopenssl s_client -connect cloud-controller-ng.service.cf.internal:9023 | openssl x509 -noout -textWhat is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@cloudfoundry/v3-acceleration-team-vat