-
Notifications
You must be signed in to change notification settings - Fork 324
Fix indefinite retry on invalid token - configurable retry #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I can confirm that this fix seems to have addressed #1032 I've run for 3 days with it and before I would see at least 2 daily issues. Now there are no memory issues. (The request that triggers the refresh now can fail and retry on its own instead of the application using up all its memory) Looking forward to a release (both on the v3 and v4 lines) |
|
@twoseat Would it be possible to release this soon? This has been plaguing Promregator users for months and we have now verified with several users this fix is working for them. I would love to update to a released version of the library so we can roll out the fix to more folks. |
|
I was holding a release pending the thumbs up on another fix. I'll chase that now, and unless I hear something bad from that I'll do a sweep of dependency updates and release this week. |
|
The other fix is OK, slight delay on my end for various reasons but I am working on the release, so should be out today or tomorrow! Thanks for your patience. |
|
Thanks again. I see the release tag was created. (https://github.com/cloudfoundry/cf-java-client/tree/v4.4.0.RELEASE) But it isn't in Maven central yet. https://mvnrepository.com/artifact/org.cloudfoundry/cloudfoundry-client-reactor (Sorry if I'm jumping the gun) Does it usually take a while to propogate? |
|
Some issues with oout CI publishing process that I'm currently working on - the |
Currently, on an InvalidTokenException the Operator retries the request indefinitely, which might be problematic as it'd lead to other issues if abused - IP based (unauthenticated requests) Rate Limit Exceeded for example.