fix docker, disk_quota and health+readiness check type serialization #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schulzh
force-pushed
the
fix-manifest
branch
from
32fc8fc to
bef27de
Compare
Contributor
|
Hello @schulzh , thank you for your contribution! |
Contributor
Author
|
Hi @anthonydahanne , I've added a unit test, could you take a look again? |
schulzh
force-pushed
the
fix-manifest
branch
from
16228c6 to
b1a5fe5
Compare
schulzh
changed the title
schulzh
force-pushed
the
fix-manifest
branch
from
116d445 to
2a6f170
Compare
schulzh
changed the title
schulzh
force-pushed
the
fix-manifest
branch
from
2a6f170 to
8117875
Compare
Contributor
Author
|
Hi @anthonydahanne , I've added two more serialization fixes to the PR. |
Lokowandtg
reviewed
May 20, 2025
Contributor
Lokowandtg
left a comment
Lokowandtg
left a comment
There was a problem hiding this comment.
lgtm
(but not tested)
Contributor
|
Hi @schulzh ! Thanks for your contribution. Would you mind rebasing on |
Contributor
Author
|
Hi @Kehrlann , i've updated the branch. |
Kehrlann
approved these changes
Jun 10, 2025
Contributor
Kehrlann
left a comment
Kehrlann
left a comment
There was a problem hiding this comment.
Looks good!
I was hoping for a rebase rather than a merge, but that's OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues we've encountered with the manifest serialization.
The first is that docker was not serialized as a deep structure, but as a string (java object representation), which breaks the yaml. The second issue is that the disk quota was not serialized with the correct field name.