Skip to content

Conversation

@IvanBorislavovDimitrov
Copy link
Contributor

@IvanBorislavovDimitrov IvanBorislavovDimitrov commented Jul 29, 2019

Hello,
The cf command-line client supports mapping of empty hosts.
For instance (getting an empty host for domain, one result): /v2/routes?inline-relations-depth=1&q=host%3A%3Bdomain_guid%3A6906bee2-0115-47f6-b7d1-3ef1e455e8e1
"%3A%3B" -> ":;"
The v3 client does not support this feature. Empty parameters are skiped and not set as parameters in the request url.
The following problem occurrs. You have two hosts mapped to domain and application.
When you try to get this empty host all of the hosts for this domain are returned.
Example:
ListSpaceRoutesRequest.Builder requestBuilder = ListSpaceRoutesRequest.builder();
requestBuilder.host(""); -> Ignored in the request (all host are returned)
This pull request removes the checks for empty parameters and allows using empty parametrs.
Could you please review it?
Regards,
Ivan

@cfdreddbot
Copy link

❌ Hey IvanBorislavovDimitrov!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process.

The following github user @IvanBorislavovDimitrov is not covered by a CLA.

After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s).

@cfdreddbot
Copy link

✅ Hey IvanBorislavovDimitrov! The commit authors and yourself have already signed the CLA.

@twoseat twoseat self-assigned this Sep 16, 2019
@twoseat twoseat added this to the 3.16.0.RELEASE milestone Sep 16, 2019
@IvanBorislavovDimitrov IvanBorislavovDimitrov force-pushed the master branch 2 times, most recently from 549692a to cf96273 Compare September 17, 2019 08:19
@twoseat twoseat closed this in 8c7f8f0 Sep 23, 2019
@twoseat twoseat merged commit 1928c0a into cloudfoundry:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants