Minor improvements for development #982
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nictas! The commit authors and yourself have already signed the CLA. |
twoseat
reviewed
Aug 12, 2019
.gitignore
Outdated
| .idea/tasks.xml | ||
| .idea/workspace.xml | ||
| target | ||
| bin |
Contributor
There was a problem hiding this comment.
I'm no expert in .gitignore + Eclipse + Windows, but the internet seems to think that this should be bin/ (or possibly /bin/ or bin/**). Can you confirm this is correct?
Contributor
Author
There was a problem hiding this comment.
I just followed the entry you have on line 4. With it you're ignoring all "target" directories by just specifying target. That seems to work fine and bin works as well - I tested it.
But you're right - bin/ is the recommended way, so I'll update the pull request. I hope you won't mind modifying the target entry to follow suit as well.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These improvements would mainly benefit people that develop on Windows or that use Eclipse instead of IntelliJ. Additionally, this pull request adds important information about building the project in an IDE, which is not obvious for people that haven't used Immutables in the past (like myself).