This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Deprecated resource type #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameowlia
approved these changes
Mar 12, 2024
jrussett
added a commit
that referenced
this pull request
Mar 14, 2024
- Follow up to PR: - #11 tl;dr; the resources returned from locket will still contain a `Type: "lock"` field, but to create the resources, you must only specify a TypeCode. - It must essentially match this locket test: cloudfoundry/locket@e0b7033...a90299e#diff-fe4d1c46f9e48a2f9db22828f37c3fe03441e794663092b2c776052b9eb4fc51L432-R433 Should resolve: ``` [FAILED] Expected <*models.Resource | 0xc0006c6230>: {Key: "test-key", Owner: "test-owner", Value: "", Type: "lock", TypeCode: 1} to equal <*models.Resource | 0xc0006c6280>: {Key: "test-key", Owner: "test-owner", Value: "", Type: "", TypeCode: 1} In [It] at: /tmp/build/f7b1384f/repo/src/code.cloudfoundry.org/cfdot/integration/locket_commands_test.go:101 @ 03/14/24 22:17:00.772 ``` Source: https://ci.funtime.lol/teams/wg-arp-diego/pipelines/diego-release/jobs/unit-and-integration-tests/builds/57#L65bb95ee:42:47
jrussett
added a commit
that referenced
this pull request
Mar 14, 2024
- Follow up to PR: - #11 tl;dr; the resources returned from locket will still contain a `Type: "lock"` field, but to create the resources, you must only specify a TypeCode. - It must essentially match this locket test: cloudfoundry/locket@e0b7033...a90299e#diff-fe4d1c46f9e48a2f9db22828f37c3fe03441e794663092b2c776052b9eb4fc51L432-R433 Should resolve: ``` [FAILED] Expected <*models.Resource | 0xc0006c6230>: {Key: "test-key", Owner: "test-owner", Value: "", Type: "lock", TypeCode: 1} to equal <*models.Resource | 0xc0006c6280>: {Key: "test-key", Owner: "test-owner", Value: "", Type: "", TypeCode: 1} In [It] at: /tmp/build/f7b1384f/repo/src/code.cloudfoundry.org/cfdot/integration/locket_commands_test.go:101 @ 03/14/24 22:17:00.772 ``` Source: https://ci.funtime.lol/teams/wg-arp-diego/pipelines/diego-release/jobs/unit-and-integration-tests/builds/57#L65bb95ee:42:47
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request to the cfdot repository!
We appreciate the contribution. To help us understand the context for your pull request, please fill out this template to the best of your ability.
Please make sure to complete all of the following steps
Please provide the following information:
What is this change about?
What problem it is trying to solve?
What is the impact if the change is not made?
How should this change be described in diego-release release notes?
Please provide any contextual information.
Tag your pair, your PM, and/or team!
Thank you!