split go-uaa

[joefitzgerald]

Per the instructions in #801 (comment), this splits go-uaa from the rest of the UAA repos so that I can continue to merge PRs as the original author and maintainer of the library.

/cc @strehle

[linux-foundation-easycla]

• ✅login: joefitzgerald / (3de822a)

The committers listed above are authorized under a signed CLA.

[strehle]

@Tallicia someone from your company should check because you use it more than we

[strehle]

@joefitzgerald if you have PR, please create them

[joefitzgerald]

@strehle please review the context from #801 (comment). In summary:

• I created the go-uaa library
• I maintained it, and worked with the UAA team to integrate it into the UAA CLI while I was at Pivotal
• The UAA team has turned over a few times since then, but I have remained a maintainer of the library; I still aspire to have the UAA / identity team maintain the library but I remain a backstop for merging of PRs that are left open for too long
• The repo was moved without consultation from the cloudfoundry-community org (where I was an org owner) to the cloudfoundry org (where I did not have any commit rights), resulting in me losing the ability to maintain the library
• This PR restores my ability to maintain the library

[beyhan]

Thanks @joefitzgerald for the pr. I will take care of this.

[joefitzgerald]

The machine appears to be once again attempting to prevent me from being a backstop maintainer of the library I contributed to a different org. I do not have the access to merge pull requests in the go-uaa repo. And I have been put on a list of people to be removed altogether from the approvers list.

1. why / how did I lose the ability to merge PRs in go-uaa
2. How can I be exempted from the annual requirement to make the same argument. It doesn’t seem like the community is growing, please don’t make it any harder than it needs to be for me to provide a service to the community.

[beyhan]

The machine appears to be once again attempting to prevent me from being a backstop maintainer of the library I contributed to a different org. I do not have the access to merge pull requests in the go-uaa repo. And I have been put on a list of people to be removed altogether from the approvers list.

1. why / how did I lose the ability to merge PRs in go-uaa
2. How can I be exempted from the annual requirement to make the same argument. It doesn’t seem like the community is growing, please don’t make it any harder than it needs to be for me to provide a service to the community.

Hi @joefitzgerald,

1. you didn't loose any right because you are still approver as listed in

   community/toc/working-groups/foundational-infrastructure.md

   Lines 179 to 203 in 7213843

   	- name: Identity and Auth (UAA) Go Client
   	approvers:
   	- name: Joe Fitzgerald
   	github: joefitzgerald
   	- name: Peter Chen
   	github: peterhaochen47
   	- name: Markus Strehle
   	github: strehle
   	- name: Hongchol Sinn
   	github: hsinn0
   	- name: Florian Tack
   	github: tack-sap
   	- name: Torsten Luh
   	github: torsten-sap
   	- name: Adrian Hoelzl
   	github: adrianhoelzl-sap
   	- name: Filip Hanik
   	github: fhanik
   	- name: Duane May
   	github: duanemay
   	reviewers:
   	- name: Prateek Gangwal
   	github: coolgang123
   	repositories:
   	- cloudfoundry/go-uaa

   . We introduced branch protection with Apply RFC0015 branch protection by default #1218 and most probably this is the reason you can't merge.
2. Just being active. Only one activity in the period of one year is required. We don't have an exception list yet with people. We don't try to make it harder but we also want to keep the list of approvers up-to-date for different reasons like security, costs, .... Is it fine to open a pr to be re-added to the role fine with you? I will take care to get it approved. With that you don't be bothered in the next year with this.

[strehle]

Only one activity in the period of one year is required

Ok fair enough, so maybe you maintain the go tool chain which needs a regular change, e.g. cloudfoundry/uaa-cli@b94faa5

[joefitzgerald]

Only one activity in the period of one year is required.

I have been merging the occasional PR, but that doesn't count as "activity". Can you please update the logic to count that as "activity"?

We introduced branch protection with #1218 and most probably this is the reason you can't merge.

So how do I regain the ability to merge PRs in the go-uaa library?

[beyhan]

Hi @joefitzgerald,

I have been merging the occasional PR, but that doesn't count as "activity". Can you please update the logic to count that as "activity"?

What counts to an activity is defined by Github and documented on this page. We just use Github APIs for that. We don't have our special logic here. The proposal by @strehle sounds like it will add activity to your profile.

The branch protection rules for go-uaa require to have one approval for the pr. In general we want to encourage the pr workflow and having reviews for transparency and security. If the pr you have, gets a review you should be able to merge. If there is an agreement among all the approvers for the go-uaa library to not require reviews this could be changed with static branch protection rule possible via https://github.com/cloudfoundry/community/blob/main/orgs/branchprotection.yml. You will need a pr and agreement between all approvers as mentioned.

Please let me know what you think about the proposals.

[beyhan]

Hi @joefitzgerald,
I wanted check about what approach would work best for you. We discussed following options until now:

1. If you'd like, you could submit a PR to re-add yourself after we merge Remove Inactive Users FI WG #1271. As we discussed, I'm happy to assist with this process, and it would help address the activity check requirements for another year.

2. Alternatively, if you're interested in participating in discussions or other maintenance activities in go-uaa, I'd be glad to remove you from Remove Inactive Users FI WG #1271.

Please let me know which option you'd prefer, or if you have any other ideas in mind.

[joefitzgerald]

@beyhan please remove me from #1271.

[beyhan]

@beyhan please remove me from #1271.

@joefitzgerald Ok, done.