Skip to content

Conversation

@poy
Copy link

@poy poy commented Sep 21, 2017

Set the instance index as meta information instead of a metric value

Signed-off-by: Andrew Poydence [email protected]

Set the instance index as meta information instead of a metric value

Signed-off-by: Andrew Poydence <[email protected]>
@cfdreddbot
Copy link

Hey apoydence!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@emalm
Copy link
Contributor

emalm commented Sep 25, 2017

Thanks, @apoydence ! Prioritizing for the Diego team to pull in soon. Does this fix any particular bugs, or is it just updating the use of the dependency?

Best,
Eric

@jasonkeene
Copy link
Contributor

@emalm This fixes an issue with go-loggregator where it was emitting application instance index as a gauge. Loggregator's conversion logic is capable of understanding this odd instance index gauge and putting in the right place. We'd like to not do this but no rush on merging.

@emalm
Copy link
Contributor

emalm commented Sep 25, 2017

Thanks, @jasonkeene, sounds good! We'll try to get to it soon, then.

@crhino crhino merged commit 357558d into cloudfoundry:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants