failure output of generate-bosh-lite-manifests is confusing

[Amit-PivotalLabs]

When ~/workspace/cf-release/bosh-lite/deployments does not exist, I see the error message from the generate-deployment-manifest that the generate-bosh-lite-manifests script delegates to:

Deployments directory '/Users/agupta/workspace/cf-release/bosh-lite/deployments' is not a directory
    Usage:
    ././scripts/generate-deployment-manifest /path/to/stub/property-overrides.yml \
       /path/to/stub/instance-count-overrides.yml \
       /path/to/stub/persistent-disk-overrides.yml \
       /path/to/stub/iaas-settings.yml \
       /path/to/stub/additional-jobs.yml \
       /path/to/stub/release-versions.yml \
       /path/to/deployment-manifests

    Ex:
    ././scripts/generate-deployment-manifest manifest-generation/bosh-lite-stubs/property-overrides.yml \
       manifest-generation/bosh-lite-stubs/instance-count-overrides.yml \
       manifest-generation/bosh-lite-stubs/persistent-disk-overrides.yml \
       manifest-generation/bosh-lite-stubs/iaas-settings.yml \
       manifest-generation/bosh-lite-stubs/additional-jobs.yml \
       manifest-generation/bosh-lite-stubs/release-versions.yml \
       ~/deployments/bosh-lite

This is confusing, and makes it look like I'm doing the wrong usage of the bosh-lite script.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/108971738.

[emalm]

Hmm, that failure message is confusing. Seems like that script should have its own validation of the expected inputs and environment, and when they are invalid should report errors about which inputs are invalid and how. At a bare minimum, it should check that CF_MANIFESTS_DIR exists and is a directory before proceeding.

Thanks,
Eric

[emalm]

Fixed in 8b208b5: generates BOSH-Lite CF manifest if not present.