Skip to content

Tps watcher cert generation #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Tps watcher cert generation #261

wants to merge 3 commits into from

Conversation

@zrob
Copy link
Contributor

@zrob zrob commented Jan 24, 2017

This is based on #240.

luan and others added 3 commits January 19, 2017 12:29
@luan @ericpromislow
Allow CA overriding when generating mutual TLS certs
365b224 
This enables the use case where Cloud Controller passes in HTTPS urls
for task callbacks that require mututal tls.
In that scenario, the CA that signs both diego and cloud controller
certificates have to be the same, this commit allows that CA to be
passed in as an argument.

Also, adds documentation to examples/aws/README.md as to how to deploy a
Diego cluster with this enabled.

Signed-off-by: Eric Promislow <[email protected]>
@luan
Pull certs from cf-release for cc.mutual_tls
8c81d5e 
Signed-off-by: Aakash Shah <[email protected]>
@zrob
Add script to generate a CC client cert for tps watcher
238ca01 
[#136436141]

Signed-off-by: Zach Robinson <[email protected]>
@cfdreddbot
Copy link

cfdreddbot commented Jan 24, 2017

Hey zrob!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

1 similar comment
@cfdreddbot
Copy link

cfdreddbot commented Jan 24, 2017

Hey zrob!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

cf-gitbot commented Jan 24, 2017

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/138205185

The labels on this github issue will be updated when the story is started.

@emalm
Copy link
Contributor

emalm commented Jan 24, 2017

Thanks, @zrob. I think this came in from the underlying #240, but could you please remove the changes for loggregator certs in examples/aws/stubs/cf/properties.yml? https://github.com/cloudfoundry/diego-release/blob/develop/examples/aws/templates/cf/stub.yml and the corresponding internal template already pull these in automatically. Also, I forgot to ask on #260, but this is blocking CAPI story https://www.pivotaltracker.com/story/show/136436141?

Best,
Eric

@aashah
Copy link

aashah commented Jan 25, 2017

I didn't have access to Zach's repo, so we had to fix this in a new PR.

Feel free to close this one.

@emalm
Copy link
Contributor

emalm commented Jan 25, 2017

Closing this out as requested, to be replaced by #262.

Thanks,
Eric

@emalm emalm closed this Jan 25, 2017
@emalm emalm mentioned this pull request Jan 25, 2017
Merged
jvshahid added a commit that referenced this pull request Jan 27, 2017
@jvshahid
Merge remote-tracking branch 'origin/pr/262' into develop
65dd433 
[finishes #138352597]
[closes #262]
[closes #261]
[closes #240]
bdshroyer pushed a commit that referenced this pull request Mar 27, 2017
bump ginkgo gomega
6f44a5b 
[finishes #142522481]

Submodule src/github.com/onsi/ginkgo c3a655f..67b9df7:
  > Remove the spec_iterator.test binary (#336)
  > Shared queue implementation for parallel tests
  > Revert "Don't colorize output by default if not writing to a TTY (#328)" (#331)
  > Don't colorize output by default if not writing to a TTY (#328)
  > Use SVG badge for build status (#330)
  > Add the ability to use ./... to recursively test directories (#319)
  > Include captured output from failed tests into JUnit (#318)
  > Aggregate flaked specs (#316)
  > Add colours for Windows in suite-runner & watch (#312)
  > Fix tests for single node machine (#311)
  > Add ability to specify a custom bootstrap file (#302)
  > Revert "remove -i in invocations of go test.  fixes #305"
  > Update .travis.yml
  > fix imports for generate command (#279)
  > Merge branch 'koron-windows-colorise'
  > remove -i in invocations of go test.  fixes #305
  > remove unnecessary variable
  > backfill GinkgoRandomSeed test
  > Expose the random seed via GinkgoRandomSeed() (#293)
  > Include flake count in test summary (#291)
  > #287 Ensure Logf/Skipf insert newline characters (#288)
  > Add package path prefix to compilation output path only if missing (#284)
  > Redo flags again, add a bunch of pass-throughs. (#282)
  > Spelling fix (#283)
  > Covermode flag (and reworked pass-through flags passing) (#281)
  > Make JUnit reporter include failure location in message. (#262)
  > remove 1.4 from travis.yml
  > Add gcflags option (#276)
  > Revert "Use the go1.5 build tag to handle vendor exceptions" (#274)
  > Merge pull request #272 from fsouza/fix-vendor
  > Add flaky test mitigation (#261)
  > Allow units and precision in benchmark (#266)
  > Add Solaris support (#264)
  > Merge pull request #259 from kwadrat/master
  > Merge branch 'apvail-spell-fix'
  > Fix go16 vendor
  > Merge pull request #250 from james-lawrence/master
  > Merge pull request #228 from jayunit100/RegexFileNameFiltering
  > Fix test flakiness
Submodule src/github.com/onsi/gomega c463cd2..334b8f4:
  > Merge pull request #206 from xoebus/patch-1
  > Merge pull request #205 from onsi/revert-201-json_formatting
  > Merge pull request #201 from madamkiwi/json_formatting
  > Merge pull request #199 from kevgo/patch-1
tas-runtime-bot added a commit that referenced this pull request Mar 11, 2024
@tas-runtime-bot
bump bbs credhub-cli ecrhelper locket routing-api garden grootfs guar…
903af2c 
…dian idmapper

Submodule src/code.cloudfoundry.org/bbs 3497ead..5d21cc4:
  > Fix go generate formatting
Submodule src/code.cloudfoundry.org/credhub-cli 6509c0be5..430737218:
  > Bump go modules
Submodule src/code.cloudfoundry.org/ecrhelper 07c96f3..ad9a664:
  > Remove logic setting RegistryIds on token requests
Submodule src/code.cloudfoundry.org/locket af84a1b5a..e0b7033ef:
  > Fix go generate format
Submodule src/code.cloudfoundry.org/routing-api 816d1f560..8d0a58ac5:
  > Update deprecated CloseNotify() call with the req.Context().Done() channel instead
Submodule src/garden 33d949f43..d50f0989a:
  > Merge pull request #114 from cloudfoundry/staticcheck
Submodule src/grootfs d005887c7..81eb0f422:
  > Update go.mod dependencies
  > Update go.mod dependencies
  > Merge pull request #261 from cloudfoundry/staticcheck
Submodule src/guardian dc161e387..b89742dc7:
  > Update go.mod dependencies
  > Pin hcsshim to v0.11.4 for containerd v1.7.13
  > Update go.mod dependencies
  > Manually resoving version for github.com/Microsoft/hcsshim
  > Update go.mod dependencies
  > Merge pull request #431 from cloudfoundry/staticcheck
Submodule src/idmapper 8d32ebfc6..65baa99d3:
  > Merge pull request #78 from cloudfoundry/staticcheck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zrob @cfdreddbot @cf-gitbot @emalm @aashah @luan