Skip to content

fix: Make the application of an ulimit to open fds configurable. #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: Make the application of an ulimit to open fds configurable. #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d298466
fix: Make the application of an ulimit to open fds configurable.
andreas-kupries May 8, 2020
fa5ed8a
fix: Make the application of an ulimit to open fds configurable.
andreas-kupries May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jobs/file_server/spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ properties:
loggregator.key:
description: "Private key for the SSH-proxy metron client certificate."

set_ulimit_fds:
description: "Set an ulimit on the number of open file descriptors. NOTE: set this property to 'false' when deploying to a containerized cloud"
default: true

set_kernel_parameters:
description: "Enable tuning /proc/sys kernel parameters. NOTE: set this property to 'false' when deploying to BOSH-Lite or other containerized BOSH clouds."
default: true
2 changes: 2 additions & 0 deletions jobs/file_server/templates/file_server_ctl.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,10 @@ case $1 in

$bin_dir/set-file-server-kernel-params

<% if p("set_ulimit_fds") %>
# Allowed number of open file descriptors
ulimit -n 100000
<% end %>

exec chpst -u vcap:vcap bash -c '/var/vcap/jobs/file_server/bin/file_server_as_vcap'

Expand Down
4 changes: 4 additions & 0 deletions jobs/rep/spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,10 @@ properties:
description: "Enable tuning /proc/sys kernel parameters. NOTE: set this property to 'false' when deploying to BOSH-Lite or other containerized BOSH clouds."
default: true

set_ulimit_fds:
description: "Set an ulimit on the number of open file descriptors. NOTE: set this property to 'false' when deploying to a containerized cloud"
default: true

containers.proxy.configuration_reload_duration:
description: "Duration of time in seconds that the rep grants the container Envoy proxy to reload its listener configuration when shutting down a container gracefully so that TLS-verifying clients will stop making connections. After this time duration, the rep will shut down other processes in the container."
default: 5s
Expand Down
2 changes: 2 additions & 0 deletions jobs/rep/templates/rep_ctl.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,10 @@ case $1 in
$bin_dir/set-rep-kernel-params
$bin_dir/setup_mounted_data_dirs

<% if p("set_ulimit_fds") %>
# Allowed number of open file descriptors
ulimit -n 100000
<% end %>

exec chpst -u vcap:vcap /var/vcap/jobs/rep/bin/rep_as_vcap

Expand Down