Skip to content

Conversation

@romain-dartigues
Copy link
Contributor

@romain-dartigues romain-dartigues commented Jan 26, 2023

This patch intend to fix the warning appearing in rep.stderr.log:

xargs: warning: options --max-args and --replace/-I/-i are mutually exclusive, ignoring previous --max-args value

As per xargs(1p): The -I, -L, and -n options are mutually-exclusive.

Thank you for submitting a pull request to the diego-release repository. We appreciate the contribution. To help us with getting better context for the pull request please follow these guidelines:

Please make sure to complete the following steps

  • Before PR Submission, Submit an issue for either an Enhancement or Bug
  • Check the Contributing document on how to sign the CLA and run tests in diego-release.
  • Make sure a pull request is done against the develop branch.

Issue Link

#688

Copy link
Member

@MarcPaquette MarcPaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@dsabeti
Copy link
Contributor

dsabeti commented Apr 27, 2023

@romain-dartigues We're hoping to merge this PR, but the tests are all still failing. I suspect it's because we've had quite a few broken builds recently. The good news is that we've got all of our test environments in good shape recently, and we have engineers paying close attention to our testing pipelines.

If you rebase on top of develop (or merge develop into your PR branch), we can work on shepherding your change through our testing pipeline, and get this PR merged.

This patch intend to fix the warning appearing in rep.stderr.log:
> xargs: warning: options --max-args and --replace/-I/-i are mutually exclusive, ignoring previous --max-args value

As per xargs(1p): The -I, -L, and -n options are mutually-exclusive.
https://man7.org/linux/man-pages/man1/xargs.1p.html
@romain-dartigues
Copy link
Contributor Author

Hi @dsabeti;
lost in the notifications I just saw your comment and rebased; here you go ;^)

@MarcPaquette
Copy link
Member

Hi @romain-dartigues,
I'm going to be focusing on this issue this week. Could you do a rebase on this issue so we can run with the most up-to-date code? The pipelines should be in better shape now.

Thanks for your understanding with this extra work,
@MarcPaquette

@MarcPaquette MarcPaquette merged commit 892b58e into cloudfoundry:develop Sep 26, 2023
@romain-dartigues romain-dartigues deleted the fix-xargs branch September 26, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants