Skip to content

Fix co-located diego manifest generation #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix co-located diego manifest generation #98

wants to merge 1 commit into from

Conversation

@cholick
Copy link
Contributor

@cholick cholick commented Nov 10, 2015

  • Add rootfses template
  • Move debug ports for tps to not collide with garden

@cholick
Fix co-located template:
1db22e4 
  * Add rootfses template
  * Move debug ports for tps to not collide with garden
@cfdreddbot
Copy link

cfdreddbot commented Nov 10, 2015

Hey cholick!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

1 similar comment
@cfdreddbot
Copy link

cfdreddbot commented Nov 10, 2015

Hey cholick!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot
Copy link

cf-gitbot commented Nov 10, 2015

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/107776522.

@emalm
Copy link
Contributor

emalm commented Nov 10, 2015

Thanks, @cholick! We on the Diego team also noticed recently that the colocated jobs were broken, and are debating whether we should even keep them around (obviously we're not testing them in any environments in CI). Are you actually using them in your deployments? If so, that's a stronger case for our retaining them and testing them in CI.

Thanks,
Eric, CF Runtime Diego PM

@cholick
Copy link
Contributor Author

cholick commented Nov 10, 2015

Yup, we plan to use co-located in our QA environment. Resources are a bit constrained there, so we were excited to see you'd already done the work to co-locate diego (we built something like this ourselves for the CF release, co-locating several jobs to reduce its footprint).

@emalm
Copy link
Contributor

emalm commented Nov 12, 2015

Great, prioritized for review.

Also, in the future, could you please submit PRs to the diego-release repo against the develop branch, instead of against master? We reserve the tip of master for our latest final BOSH release.

Thanks again,
Eric

@cholick
Copy link
Contributor Author

cholick commented Nov 12, 2015

Will do; sorry, I missed that in the contributing guide.

@emalm
Copy link
Contributor

emalm commented Nov 12, 2015

No problem -- the notice is in https://github.com/cloudfoundry-incubator/diego-release/blob/develop/CONTRIBUTING.md, but it's too difficult to see, especially on a first read. I'll update it with some better formatting shortly.

Best,
Eric

@sykesm sykesm closed this in 76b73f3 Nov 18, 2015
@sykesm
Copy link
Contributor

sykesm commented Nov 18, 2015

@cholick,

Thanks for the contribution. We manually put these changes into our develop branch.

@sykesm & @DanLavine

jvshahid added a commit that referenced this pull request Jun 18, 2018
@jvshahid
bump diego-ssh uaa-go-client jwt-go
4081347 
[finishes #155485548](https://www.pivotaltracker.com/story/show/155485548)

Submodule src/code.cloudfoundry.org/diego-ssh 9b3f460..1174556:
  > Upgrade jwt-go library.
Submodule src/code.cloudfoundry.org/uaa-go-client 0c176509..26b271e3:
  > Ignore validation error when token used before issued
  > go back to using submodules from routing-release
  > Provide correct url
  > Update README
  > all tests passing with newer JWT
  > fixing vet errors
  > Merge pull request #10 from cloudfoundry-incubator/vendor-deps
  > Revert "remove incubator"
  > remove incubator
Submodule src/github.com/dgrijalva/jwt-go f62f64ea..06ea1031:
  > documentation around expected key types
  > Merge branch 'master' of github.com:dgrijalva/jwt-go
  > add options to ParseFromRequest
  > fixed a formatting error in a test
  > documenting changes for upcoming 3.2.0 release
  > Merge pull request #152 from pusher/parse-unverified
  > Merge pull request #219 from geertjanvdk/feat/parse
  > Merge pull request #205 from zamicol/icon_godoc
  > Merge pull request #209 from zhyuri/patch-1
  > Merge pull request #220 from polarina/readme-alt-include
  > Notice about upcoming 4.0.0 release
  > 3.1.0 changelog
  > Merge pull request #218 from zoofood/patch-1
  > updated note on alg type vulnerability
  > Merge pull request #183 from hnakamur/support_rs256_in_jwt_command
  > Merge pull request #196 from dgrijalva/dg/cmd_args
  > Merge pull request #190 from jamesrwhite/patch-1
  > Merge pull request #180 from kevinburke/fix-unreachable
  > Merge pull request #166 from johnlockwood-wf/issue-165-missing-arg
  > Merge pull request #151 from zaichang/FixMigrationGuide
  > Merge pull request #146 from pkieltyka/master
  > Merge pull request #140 from kazhuravlev/patch-1
  > Merge pull request #77 from dgrijalva/release_3_0_0
  > v2.7.0
  > notice about imminent 3.0.0
  > Merge pull request #136 from bruston/keyfunc-typo
  > fixes #135 copy/paste error in rsa decoding tools
  > Merge pull request #132 from abourget/master
  > Merge pull request #133 from johnlockwood-wf/expire-delta
  > release notes
  > expose inner error within ValidationError
  > Merge branch 'master' of https://github.com/emanoelxavier/jwt-go-contr into dg/merge_112
  > cleaned up style and added tests
  > Merge branch 'master' of https://github.com/dakom/jwt-go into dg/pr_121
  > version history update
  > Merge pull request #79 from dgrijalva/dg/none
  > Merge pull request #122 from appleboy/patch-1
  > add 1.6 to travis.yml
  > Merge pull request #107 from Snorlock/bearer-verification
  > Merge pull request #111 from matm/master
  > added supported signing methods
  > Added some clarification and (hopefully) helpful documentation
  > version history
  > signature should be populated after parsing a valid token
  > Merge pull request #98 from dgrijalva/dg/parser
  > use cleaner version of prefix checking (thanks shurcooL)
  > fix array OOB panic (#100)
  > Merge pull request #93 from EnerfisTeam/master
  > Merge branch 'master' of github.com:dgrijalva/jwt-go
  > minor refactor of HMAC verify for legibility.  no functional changes
  > updated documenation of SigningMethod interface
@peanball peanball mentioned this pull request Apr 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cholick @cfdreddbot @cf-gitbot @emalm @sykesm