Drop support for node 16 #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c2fe380 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
calebeby
requested review from
Paul-Hebert,
gerardo-rodriguez and
spaceninja
spaceninja
approved these changes
Sep 20, 2023
Member
|
Does the version of Node this repo uses affect consumers of our eslint library? |
Member
Author
|
Yes. Consumers of this eslint library will get install warnings if they try to update this dependency without also updating node to a supported version. (once we publish a new version of this library). They can continue to use the older version of the eslint config if they are unable to update node right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 16 is EOL as of last week. Hoping this might fix #566 (comment) since it looks like renovate is using npm@10, and npm@10 only supports node 18+.
Not sure if this will fix it though since renovate's update process doesn't depend on GH actions and might not read the
enginesfield in package.json