BUG: Handle instance methods of builtin types.

[ssanderson]

Fixes a crash in Python 2 when serializing non-hashable instancemethods
of built-in types.

Fixes #144.

[codecov-io]

Codecov Report

Merging #145 into master will increase coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   83.79%   83.91%   +0.11%     
==========================================
  Files           1        1              
  Lines         537      541       +4     
  Branches       98       98              
==========================================
+ Hits          450      454       +4     
  Misses         63       63              
  Partials       24       24

Impacted Files	Coverage Δ
cloudpickle/cloudpickle.py	83.91% <100%> (+0.11%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03292a3...8a41060. Read the comment docs.

[llllllllll]

lgtm!

[mrocklin]

Thanks for identifying and fixing this Scott!

…

On Wed, Dec 27, 2017 at 10:30 PM, Joe Jevnik ***@***.***> wrote: lgtm! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#145 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASszDN3zFNmlARGGupa1W52tlpuhchmks5tEzVxgaJpZM4ROCHK> .

[HyukjinKwon]

Hi all, while Apache Spark is trying to match the cloudpickle copy in Apache Spark to 0.4.2v, for now, I found this bug fix, which seems introduced from #113. Seems 0.4.2v has this issue -
https://github.com/cloudpipe/cloudpickle/blob/v0.4.2/cloudpickle/cloudpickle.py#L332-L342 , if I didn't missed.

Do we have a kind of backporting policy here? If we have, I would like to suggest to backport this, if I understood correctly.

If there is no for now, let me just suggest to port this patch alone into PySpark's cloudpickle copy.

[HyukjinKwon]

I can push a branch "0.4.x" here and help backporting bugs in this repo as I believe I would be in this affair for a while. Please let me know if you guys are interested in this, or I missed previous discussion about this.

[rgbkrk]

We'd be happy to have maintenance on branches, so if you're willing to take up the mantle that's ok @HyukjinKwon.

[HyukjinKwon]

Ah, thank you so much 👍 . Let me try it on this weekend.

[HyukjinKwon]

I have just pushed branch called "0.4.x" after checking out to v0.4.2 - https://github.com/cloudpipe/cloudpickle/tree/0.4.x.

Will open few PRs against this branch.