Skip to content

Conversation

@goruha
Copy link
Member

@goruha goruha commented Aug 20, 2022

what

  • Added deploy action

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

@@ -0,0 +1,22 @@
FROM cloudposse/geodesic:0.147.11-alpine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW   Ensure a user for the container has been created
    Resource: /Dockerfile. | ID: BC_DKR_3

Description

Containers should run as a non-root user. It is good practice to run the container as a non-root user, where possible. This can be done either via the ```USER``` directive in the ```Dockerfile``` or through ```gosu``` or similar where used as part of the ```CMD``` or ```ENTRYPOINT``` directives.

Benchmarks

  • CIS DOCKER V1.2 4.1

@@ -0,0 +1,22 @@
FROM cloudposse/geodesic:0.147.11-alpine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW   Ensure healthcheck instructions have been added to container images
    Resource: /Dockerfile. | ID: BC_DKR_2

Description

We recommend that you add the HEALTHCHECK instruction to your Docker container images to ensure that health checks are executed against running containers.

An important security control is that of availability. Adding the HEALTHCHECK instruction to your container image ensures that the Docker engine periodically checks the running container instances against that instruction to ensure that containers are still operational.

Based on the results of the health check, the Docker engine could terminate containers which are not responding correctly, and instantiate new ones.

Benchmarks

  • CIS DOCKER V1.2 4.6

@goruha goruha merged commit 894028f into main Aug 20, 2022
@goruha goruha deleted the init branch August 20, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants