Support PHP 8.1 and minor clean up #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
changed the title
SimonFrings
force-pushed
the
php8
branch
2 times, most recently
from
e3a9d1f to
f71621d
Compare
clue
approved these changes
Jun 23, 2022
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds support for PHP 8.1 and adds
convertDeprecationsToExceptions="true"to thephpunit.xmlconfiguration to make sure we'll see future deprecation notices.Builds on top of #30.