Migrate indicators to a common add_prefix() library
#368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@sgsmob FYI you have a merge conflict |
chinandrew
reviewed
Oct 27, 2020
chinandrew
reviewed
Oct 27, 2020
chinandrew
reviewed
Oct 27, 2020
Co-authored-by: chinandrew <[email protected]>
chinandrew
reviewed
Oct 27, 2020
Contributor
|
|
chinandrew
reviewed
Oct 27, 2020
Contributor
|
Good to approve once that comment on adding dependency to setup is resolved. |
chinandrew
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a series of identical
add_prefix()andpublic_signal()definitions duplicated across indicators into single definitions indelphi_utils.Also fixes lint errors in the files already touched by this PR.