Skip to content

Conversation

@chinandrew
Copy link
Contributor

Closes #384

Summary of changes:

  • Delete the deprecated cds/, emr_hosp/, and google_health/ directories.

I tagged this commit but I'm not sure how to view the tags on github. If anyone can verify please let me know.

@capnrefsmmat
Copy link
Contributor

Note that you need git push --tags to actually push tags to a remote.

@krivard
Copy link
Contributor

krivard commented Oct 27, 2020

I led you astray: google_health is deprecated, but is still in production while we work on the new GS indicator.

(also: tags can be viewed here, & linked from the front page next to "63 branches")

@chinandrew
Copy link
Contributor Author

I led you astray: google_health is deprecated, but is still in production while we work on the new GS indicator.

Does this mean we should hold off on deleting until then? Either by only deleting the other two or just waiting and deleting all 3 at once.

(also: tags can be viewed here, & linked from the front page next to "63 branches")

👍 Thanks

@krivard
Copy link
Contributor

krivard commented Oct 28, 2020

@benjaminysmith @korlaxxalrok Thoughts?

  • Delete all 3 now, and freeze the deploy-ght branch so the production deployment stays in place. Possible footgun if someone forgets.
  • Delete all 3 later, once GS is ready. Adds to the stack of things to remember to do later.
  • Delete the other 2 now, delete GHT later once GS is ready. Adds to the stack of things to remember to do later (though might be a natural step of deploying GS)

@benjaminysmith
Copy link
Contributor

Delete the other 2 now, delete GHT later once GS is ready. Adds to the stack of things to remember to do later (though might be a natural step of deploying GS)

I prefer this one. If it's not too much work to split, this sounds like the choice that requires least mental load.

@krivard
Copy link
Contributor

krivard commented Oct 28, 2020

Excellent, let's go with that then. @chinandrew you good to implement? Prefer force-updating the existing tag to adding a new one.

@chinandrew
Copy link
Contributor Author

Excellent, let's go with that then. @chinandrew you good to implement? Prefer force-updating the existing tag to adding a new one.

It may just be easier to delete the existing tag and adding a new one given that I have a self inflicted merge conflict. If there's a clean way around that let me know.

@chinandrew
Copy link
Contributor Author

Tag updated and reused in #394

@chinandrew chinandrew closed this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated indicators cds and emr_hosp from repo.

5 participants