Skip to content

Conversation

@dshemetov
Copy link
Contributor

This is a test, but should really be all the changes we need for #47 .

kenmawer and others added 30 commits May 24, 2022 16:19
Issue #22 of uniting lag and ahead functions.
Merge branch 'main' of https://github.com/kenmawer/epipredict into km-issue_22_unite

# Conflicts:
#	R/epi_lag.R
@dshemetov dshemetov requested a review from brookslogan June 13, 2022 22:04
@dshemetov
Copy link
Contributor Author

@brookslogan CI is getting this error (got it locally too). Any ideas?

Error: Error: processing vignette 'knn-forecasts.Rmd' failed with diagnostics:
C stack usage  15945684 is too close to the limit

@dshemetov
Copy link
Contributor Author

dshemetov commented Jun 13, 2022

Meged main in and there were no conflicts. It looks like @dajmcdon may have already done this in a68e901. This should help with the diffs in other PRs that may have branched off of main instead of frosting (like #48).

  • Still need to fix whatever CI stack error is happening in the KNN vignette.

@dshemetov dshemetov changed the title Add frosting to CI Add frosting to CI and sync with main Jun 14, 2022
Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, aside from the cleanliness of the as_tibble.epi_df approach which will be addressed in a separate issue. [The original approach was just minimally edited to avoid infinite recursion in the knn vignette when epiprocess and epipredict are both loaded. It is still probably asking for some unintended behavior down the line.]

@dshemetov dshemetov merged commit ba0d8b5 into frosting Jun 14, 2022
@dshemetov dshemetov deleted the ds/frosting-ci branch June 14, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants