Skip to content

Make sure score explanations appear at the right time #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Make sure score explanations appear at the right time #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions app/server.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ updateAheadChoices <- function(session, df, targetVariable, forecasterChoices, a
if (targetVariable == "Hospitalizations") {
aheadOptions <- HOSPITALIZATIONS_AHEAD_OPTIONS
title <- "Forecast Horizon (Days)"
show("horizon-disclaimer")
showElement("horizon-disclaimer")
} else {
aheadOptions <- AHEAD_OPTIONS
title <- "Forecast Horizon (Weeks)"
hide("horizon-disclaimer")
hideElement("horizon-disclaimer")
}
aheadChoices <- Filter(function(x) any(unique(df$ahead) %in% x), aheadOptions)
# Ensure previsouly selected options are still allowed
Expand Down Expand Up @@ -592,28 +592,28 @@ server <- function(input, output, session) {
showElement("showForecastsCheckbox")
}
if (input$scoreType == "wis") {
show("wisExplanation")
hide("sharpnessExplanation")
hide("aeExplanation")
hide("coverageExplanation")
showElement("wisExplanation")
hideElement("sharpnessExplanation")
hideElement("aeExplanation")
hideElement("coverageExplanation")
}
if (input$scoreType == "sharpness") {
show("sharpnessExplanation")
hide("wisExplanation")
hide("aeExplanation")
hide("coverageExplanation")
showElement("sharpnessExplanation")
hideElement("wisExplanation")
hideElement("aeExplanation")
hideElement("coverageExplanation")
}
if (input$scoreType == "ae") {
hide("wisExplanation")
hide("sharpnessExplanation")
show("aeExplanation")
hide("coverageExplanation")
hideElement("wisExplanation")
hideElement("sharpnessExplanation")
showElement("aeExplanation")
hideElement("coverageExplanation")
}
if (input$scoreType == "coverage") {
hide("wisExplanation")
hide("sharpnessExplanation")
hide("aeExplanation")
show("coverageExplanation")
hideElement("wisExplanation")
hideElement("sharpnessExplanation")
hideElement("aeExplanation")
showElement("coverageExplanation")
}
})

Expand Down Expand Up @@ -657,11 +657,11 @@ server <- function(input, output, session) {
observe({
# Show data loading message and hide other messages until all data is loaded
if (DATA_LOADED) {
hide("data-loading-message")
show("refresh-colors")
show("notes")
show("scoreExplanations")
show("scoringDisclaimer")
hideElement("data-loading-message")
showElement("refresh-colors")
showElement("notes")
showElement("scoreExplanations")
showElement("scoringDisclaimer")
}
# Ensure there is always one ahead selected
if (length(input$aheads) < 1) {
Expand Down