Flesh out imageTag in makefile
#289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsweber2
reviewed
May 31, 2023
krivard
approved these changes
May 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dsweber2 noticed that "the variable
imageTagin the makefile isn't defined; presumably its an environmental variable, but it isn't mentioned in the readme at all". I've set a default forimageTagin the Makefile and described it's use, BUT it turns out that the twomaketargets that use this variable aren't used anywhere else in our code. Building, tagging, and releasing is done explicitly in theci.yamlworkflow rather than usingmake.These two targets could be useful if we need to manually build and release a docker image for production (e.g. something goes wrong with the automated release process while we're trying to release a hotfix). But we haven't needed this yet and it does make the code longer. I'm open to arguments either way.
Fixes #287