only trigger workflow on push to dev #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tildechris
approved these changes
Mar 9, 2021
| push: | ||
| branches: [ dev ] | ||
| pull_request: | ||
| branches: [ dev ] |
There was a problem hiding this comment.
Can you think of a sanity check / unit test that we can still do here?
There was a problem hiding this comment.
We don't need to consider it in the scope of this PR, but some sort of check would be good. Perhaps https://github.com/jimhester/lintr with check syntax checking to start?
There was a problem hiding this comment.
Sounds good, I will add an issue for that.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.