Skip to content

docker refactor for stable environment to convert Rmd blog post to html #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2023
Merged

docker refactor for stable environment to convert Rmd blog post to html #760

merged 3 commits into from
Feb 2, 2023

Conversation

minhkhul
Copy link
Contributor

@minhkhul minhkhul commented Jan 31, 2023 •
edited
Loading

Description

  • Replace miniconda base + mamba install with mambaorg/micromamba base image, reducing container build time by half.
  • Adjust R dependencies and environment.yml to reflect recent changes in R packages.
  • Pins reticulate at 1.22 to avoid a conda path problem with versions 1.23-28.

Test

Rebuilt all blog post with setup produces passing results.
Screenshot 2023-01-31 at 11 41 19 AM

@netlify
Copy link

netlify bot commented Jan 31, 2023 •
edited
Loading

✅ Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit b9081fd
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/63dbfc74626d9a0008a89735
😎 Deploy Preview https://deploy-preview-760--cmu-delphi-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@minhkhul minhkhul changed the title docker refactor for stable environment to convert Rmd to html docker refactor for stable environment to convert Rmd blog post to html Jan 31, 2023
@minhkhul minhkhul requested a review from krivard January 31, 2023 16:50
krivard
krivard approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 can merge as-is or drop commented-out code if we don't need it

@minhkhul @krivard
Update devops/r.dockerfile
b9081fd 
Co-authored-by: Katie Mazaitis <[email protected]>
@minhkhul minhkhul merged commit 0689f0a into dev Feb 2, 2023
@minhkhul minhkhul deleted the docker-mambaorg-micromamba branch February 2, 2023 18:10
@krivard krivard mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krivard krivard krivard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@minhkhul @krivard