Update room.urdf.xacro for noetic #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, Michael, for taking care of the review! |
NeumannM89
approved these changes
Jan 12, 2022
|
@sunava or @hawkina could you checkthe two latest commits in this pr? They change the Shouldve opened a new PR for that but accidentally pushed to the existing one, sorry. |
sunava
reviewed
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and the other xacro files in iai_kitchen_defs as well. Adds
xacroprefixes to all native and custom macros within iai_kitchen_defs. This is needed for urobosim. The kitchen's urdf is untouched by this PR, it will be covered in a separate PR.I didn't see any launch file use the xacros in iai_kitchen_defs except for
iai_maps/launch/room.launch.I tested this PR by comparing the old room in melodic with this new one in noetic, they look the same. But the walls around the kitchen (where the tables are on which we put our laptops and work and stuff) are outdated and need to be moved. Changing any parameters is not part of this PR though.