Skip to content

Block level nesting audit #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 21, 2024
Merged

Block level nesting audit #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12e9cc5
Merge pull request #66 from code4rena-dev/develop
leo95oliveira May 14, 2024
e3af446
paragraph audit
SamusElderg May 17, 2024
1d402c9
console log audit
SamusElderg May 17, 2024
4b72d95
img alt audit
SamusElderg May 17, 2024
ec02718
bump version for rls
SamusElderg May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@code4rena/components-library",
"version": "4.0.2",
"version": "4.0.3",
"description": "Code4rena's official components library ",
"types": "./dist/lib.d.ts",
"exports": {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/Card/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const Card = ({
{(footerDetails || footerLinks) && (
<footer className="card__footer">
{footerDetails && (
<p className="card__footer-details">{footerDetails}</p>
<div className="card__footer-details">{footerDetails}</div>
)}
{footerLinks && (
<div className="card__footer-link-wrapper">
Expand Down
8 changes: 4 additions & 4 deletions src/lib/ContestTile/DefaultTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ function IsContest({
</a>
</h2>
{/* Contest description */}
<p className="description">
<div className="description">
{description}{" "}
{((hasBotRace && contestTimelineObject && (contestTimelineObject.botRaceStatus === Status.UPCOMING ||
contestTimelineObject.botRaceStatus === Status.LIVE))
Expand Down Expand Up @@ -344,7 +344,7 @@ function IsContest({
size={TagSize.NARROW} />
)}
</div>}
</p>
</div>
</div>
</header>
{/* Reward pool amount */}
Expand Down Expand Up @@ -464,7 +464,7 @@ function IsBounty({
</a>
</h2>
{/* Contest description */}
<p className="description">
<div className="description">
{description}
{(ecosystem || (languages && languages.length > 0)) && <div className="tags">
{ecosystem && <Tag
Expand All @@ -482,7 +482,7 @@ function IsBounty({
size={TagSize.NARROW} />
)}
</div>}
</p>
</div>
</div>
</header>
{/* Reward pool amount */}
Expand Down
2 changes: 0 additions & 2 deletions src/lib/Input/Input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,6 @@ export const Input = ({
}
}
if (required) {
console.log(selectValue);

if (variant !== InputVariant.SELECT && (value === "" || value == null)) {
errorMessages.push("This field is required");
} else if (
Expand Down
2 changes: 1 addition & 1 deletion src/lib/Tag/Tag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const Tag = ({

return (
<div id={id ?? undefined} className={`${styling} ${className}`}>
{iconLeft && typeof iconLeft === "string" && <img alt="" src={iconLeft} width={16} height={16} />}
{iconLeft && typeof iconLeft === "string" && <img alt="left-icon" src={iconLeft} width={16} height={16} />}
{iconLeft && typeof iconLeft !== "string" && <div className="icon">
{iconLeft}
</div>}
Expand Down