Skip to content

Conversation

@JJ27
Copy link
Contributor

@JJ27 JJ27 commented Jul 25, 2020

Josh Joseph

Jingle Bell Relays(problems 1-5)
Chapter 11

Original Problem by Christopher Haver, Computer Science Teacher at SBHS in NJ
Solutions written by me(Josh Joseph)

5 problems that get progressively more difficult from 1-5. When you get the correct answer, a "You win" graphic appears.

JJ27 and others added 3 commits July 25, 2020 17:19
Add Jingle Relay problems to Ch. 11 Java
Create solutions to Jingle Bell Relay Problems
@JJ27 JJ27 requested review from ARajan1084 and phrdang July 25, 2020 22:10
Copy link
Contributor

@ARajan1084 ARajan1084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that is a lot of practice problems

@JJ27 JJ27 requested a review from AlveeraMunshi July 25, 2020 22:56
Copy link
Member

@AlveeraMunshi AlveeraMunshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all have same, correct output as intended so your good and the linting looks fine as far as I know

@phrdang
Copy link
Member

phrdang commented Jul 26, 2020

@JJ27 You may want to check the output for the Java (Checkstyle) check so that you can merge. Let @abhatia1205 (Anant) know if it the warnings are overkill, if so he should use his admin privileges to merge manually.

@abhatia1205
Copy link
Contributor

Awesome practice problems and the formatting looks good enough, so I'm gonna go ahead and merge!

@abhatia1205 abhatia1205 merged commit d36ed92 into master Jul 26, 2020
@abhatia1205 abhatia1205 deleted the JoshJ-JingleBellRelay branch July 26, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants