Skip to content

Fix imports and misc errors #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2021
Merged

Fix imports and misc errors #26

merged 3 commits into from
Jul 7, 2021

Conversation

@phrdang
Copy link
Member

@phrdang phrdang commented Jul 1, 2021

Changes

  • Remove unused imports from Average, Lexico classes
  • Import java.util classes explicitly in Access, Names, and Sort classes to avoid generics error
  • Close Scanner object in Names.java
  • Suppress unused variable warnings in Access.java

Affected Sections/Problems

  • 14.7 Practice
    • Lexicographical Order
    • Average
  • 16.6 Practice
    • Access
    • Names
    • Sort

phrdang added 2 commits July 1, 2021 11:34
@phrdang
Remove unused imports from Average, Lexico
dd849b6
@phrdang
Import java.util classes explicitly
f15d68e 
- Close Scanner in Names.java
- Suppress unused warning in Access.java
@phrdang phrdang requested review from AlveeraMunshi and JJ27 July 1, 2021 18:41
@phrdang phrdang removed the request for review from AlveeraMunshi July 1, 2021 20:20
@JJ27 JJ27 merged commit 8f6745c into master Jul 7, 2021
@JJ27 JJ27 deleted the fix-imports branch July 7, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JJ27 JJ27 JJ27 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

practice problem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phrdang @JJ27