stubbing out results view #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your fake result is missing a comma, but otherwise looks good. You might wanna leave a comment in the home.ejs file that pulling in jquery and bootstrap js outside the bundle is just a temporary hack until the results view is finished. Ultimately we shouldn't depend on those, instead using native react components to do things like show modals and whatnot. I believe there is a react-bootstrap if you wanna go that route |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stubbed out an implementation @chrisbeaman 's codepen for lists in react components.
http://codepen.io/chrisbeaman/full/WvOjoM
There is only one result, and it is hard-coded. I'm not sure how data should be structured when it gets passed to a result item component. ( I have rough idea in util/results.json of how it could look )