Skip to content

Initial work on Notebooks #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 79 commits into from
May 6, 2024
Merged

Initial work on Notebooks #165

merged 79 commits into from
May 6, 2024

Conversation

@worksofliam
Copy link
Member

@worksofliam worksofliam commented Nov 10, 2023 •
edited
Loading

  • Initial port from vscode-ibmi-notebooks
  • Ability to open existing .sql sources as a new Notebook, separating statements into separate cells (SQL files have a button to open as a notebook)
  • Consider how we can generate different formats of data other than tables for relational data (we added charts!)
  • Add chart width (max-width?) settings to extension
  • Ability to create a new empty Notebook from the SQL Job Manager view, similar to how we have a 'new empty file' button
  • New Notebook examples under the Examples view (API has been added isNotebook)
  • Reset result set view when cell is executed
  • Comma at the end of statements supported
  • Docs on Notebooks - requires dev work to be finished

@github-actions
Copy link

github-actions bot commented Nov 10, 2023

👋 A new build is available for this PR based on eb5ad4a.

@worksofliam worksofliam linked an issue Nov 10, 2023 that may be closed by this pull request
Migrate away from vscode-ibmi-notebooks in favour of vscode-db2i #150
Closed
@github-actions
Copy link

github-actions bot commented Nov 13, 2023

👋 A new build is available for this PR based on 3a74947.

@github-actions
Copy link

github-actions bot commented Nov 13, 2023

👋 A new build is available for this PR based on 4695940.

@github-actions
Copy link

github-actions bot commented Nov 14, 2023

👋 A new build is available for this PR based on 1af0e28.

@github-actions
Copy link

github-actions bot commented Nov 18, 2023

👋 A new build is available for this PR based on d55091a.

@worksofliam worksofliam linked an issue Feb 22, 2024 that may be closed by this pull request
Run Cell in INB document does not run with same code as CTRL+R #203
Closed
@github-actions
Copy link

github-actions bot commented Feb 28, 2024

👋 A new build is available for this PR based on f581689.

@worksofliam
Improvement to API names
318a5aa 
Signed-off-by: worksofliam <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 3, 2024

👋 A new build is available for this PR based on f96ab67.

@github-actions
Copy link

github-actions bot commented Apr 9, 2024

👋 A new build is available for this PR based on 93ffd79.

@github-actions
Copy link

github-actions bot commented Apr 17, 2024

👋 A new build is available for this PR based on 7c3b8dc.

@github-actions
Copy link

github-actions bot commented Apr 25, 2024

👋 A new build is available for this PR based on bffd82e.

@github-actions
Copy link

github-actions bot commented Apr 26, 2024

👋 A new build is available for this PR based on 5bbdeef.

@worksofliam
Initial work on export
3c44633 
Signed-off-by: worksofliam <[email protected]>
@worksofliam
Improved printing
5e3b79e 
Signed-off-by: worksofliam <[email protected]>
@worksofliam
Improve css for Notebook cells
9481b52 
Signed-off-by: worksofliam <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 26, 2024

👋 A new build is available for this PR based on 9481b52.

@worksofliam
Cleanup of cell variables
fce1554 
Signed-off-by: worksofliam <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 29, 2024

👋 A new build is available for this PR based on fce1554.

@github-actions
Copy link

github-actions bot commented Apr 30, 2024

👋 A new build is available for this PR based on d3a969d.

@worksofliam worksofliam added this to the 1.0.0 milestone May 1, 2024
@github-actions
Copy link

github-actions bot commented May 2, 2024

👋 A new build is available for this PR based on 5f2b28a.

@github-actions
Copy link

github-actions bot commented May 2, 2024

👋 A new build is available for this PR based on 009157c.

@github-actions
Copy link

github-actions bot commented May 2, 2024

👋 A new build is available for this PR based on 5046148.

forstie
forstie approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@forstie forstie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rockin

@worksofliam worksofliam merged commit 21b3100 into main May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@forstie forstie forstie approved these changes

@davecharron davecharron Awaiting requested review from davecharron

Assignees

No one assigned

Labels

ready The tag should be taken off if it is being worked on, or if a review fails

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

Run Cell in INB document does not run with same code as CTRL+R Migrate away from vscode-ibmi-notebooks in favour of vscode-db2i

4 participants

@worksofliam @forstie @davecharron