Skip to content

Feature/cancel #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Mar 6, 2024
Merged

Feature/cancel #195

merged 23 commits into from
Mar 6, 2024

Conversation

@worksofliam
Copy link
Member

@worksofliam worksofliam commented Feb 8, 2024 •
edited
Loading

Shows cancel button when running an SQL statement.

  • Cancels the statement when switching job in the Job Manager
  • Cancel button is shown during statement execution
  • Cancel button is shown during explain execution
  • Cancel button is shown during csv, json, etc, execution
  • Running a statement while one is already running will cancel the previous statement <- we're not doing that now
  • Optional: updating the SQL Job node based on the busy state

@github-actions
Copy link

github-actions bot commented Feb 8, 2024

👋 A new build is available for this PR based on ef97bf9.

@github-actions
Copy link

github-actions bot commented Feb 13, 2024

👋 A new build is available for this PR based on 670e012.

@worksofliam
Restore cancel after merge
4729b5b 
Signed-off-by: worksofliam <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 13, 2024

👋 A new build is available for this PR based on 4729b5b.

@worksofliam worksofliam marked this pull request as ready for review February 21, 2024 20:19
@worksofliam
Additional comment
a434850 
Signed-off-by: worksofliam <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 21, 2024

👋 A new build is available for this PR based on a434850.

@worksofliam worksofliam added this to the 0.8.0 milestone Feb 22, 2024
@worksofliam worksofliam mentioned this pull request Feb 22, 2024
Closed
@worksofliam worksofliam mentioned this pull request Feb 29, 2024
Closed
@github-actions
Copy link

github-actions bot commented Feb 29, 2024

👋 A new build is available for this PR based on 1bfd35f.

@github-actions
Copy link

github-actions bot commented Feb 29, 2024

👋 A new build is available for this PR based on 7793eb4.

@github-actions
Copy link

github-actions bot commented Feb 29, 2024

👋 A new build is available for this PR based on 60626bc.

@worksofliam
Remove cancel logic
6c221bc 
Signed-off-by: worksofliam <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 29, 2024

👋 A new build is available for this PR based on 6c221bc.

@github-actions
Copy link

github-actions bot commented Mar 5, 2024

👋 A new build is available for this PR based on e1103dc.

@github-actions
Copy link

github-actions bot commented Mar 5, 2024

👋 A new build is available for this PR based on 711e942.

@github-actions
Copy link

github-actions bot commented Mar 5, 2024

👋 A new build is available for this PR based on 2309d48.

@worksofliam
Fix bug on commit control UI
4f830df 
Signed-off-by: worksofliam <[email protected]>
@github-actions
Copy link

github-actions bot commented Mar 5, 2024

👋 A new build is available for this PR based on 4f830df.

@github-actions
Copy link

github-actions bot commented Mar 5, 2024

👋 A new build is available for this PR based on e649d74.

@github-actions
Copy link

github-actions bot commented Mar 5, 2024

👋 A new build is available for this PR based on 8c6e9b5.

@worksofliam worksofliam linked an issue Mar 6, 2024 that may be closed by this pull request
Prevent output channel IBM i from appearing when SQL statement prefix is present #200
Closed
@github-actions
Copy link

github-actions bot commented Mar 6, 2024

👋 A new build is available for this PR based on 5c72dc4.

davecharron
davecharron approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@davecharron davecharron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any blockers to merging.

@worksofliam
Correct spelling of variable
95d83c7 
Signed-off-by: worksofliam <[email protected]>
@worksofliam worksofliam merged commit 355a3b7 into main Mar 6, 2024
@github-actions
Copy link

github-actions bot commented Mar 6, 2024

👋 A new build is available for this PR based on 95d83c7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davecharron davecharron davecharron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.8.0

Development

Successfully merging this pull request may close these issues.

Prevent output channel IBM i from appearing when SQL statement prefix is present

3 participants

@worksofliam @davecharron