Fixed schema objects ordering #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seb Julliand <[email protected]>
chrjorgensen
approved these changes
Feb 20, 2024
Contributor
There was a problem hiding this comment.
@sebjulliand Good catch - Mr. SqlGuru! 😉
I approved - but it seems not to be accepted by GitHub... could it be me not having write access to this repo?
davecharron
requested changes
Feb 20, 2024
davecharron
reviewed
Feb 20, 2024
Signed-off-by: Seb Julliand <[email protected]>
Member
Author
|
Thank you for your review and your suggestion @davecharron 🙏🏻 |
Member
|
Tests are passing. Thanks @sebjulliand!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197
The query run when fetching the objects for the schemas browser was supposed to order the items alphabetically but the
Select * (...) Union Allapplied to join the queries would prevent it.This PR fixes this and restores the alphabetical order in the schemas browser.