Skip to content

Feature/new self codes #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Mar 22, 2024
Merged

Feature/new self codes #207

merged 28 commits into from
Mar 22, 2024

Conversation

@ajshedivy
Copy link
Collaborator

@ajshedivy ajshedivy commented Mar 8, 2024 •
edited by worksofliam
Loading

Issues:

TODO

  • better check for os version and ptf levels, see

    vscode-db2i/src/config.ts

    Line 21 in c1e7da1

    const featureRequirements = {
    (Liam - met with Scott, he said current logic should work ok)
  • Self Code default enablement (Liam)
  • Use decoration provider for hit count in SELF Code view instead of in the node description (we already do this for Dove written by Dave!)
  • Configuration option to have auto-refresh enabled/disabled automatically
  • Make use of viewsWelcome in package.json for when there are no SELF code errors.
  • Fix SQL statement to clear SELF logs:
    image
  • Button on the SELF error to copy the SQL statement to the clipboard
  • Show reason code when it's not null
  • Update SELF code tests
  • Change titles of SELF quick pick and view to full name
    • Quick pick: 'Set logging level for SELF'
    • View: 'SQL Error Log Facility (SELF)'
  • Add button in SELF view to open the docs: https://www.ibm.com/docs/en/i/7.5?topic=tools-sql-error-logging-facility-self

Things to test:

  • Ensure self codes are stored into saved settings
  • Ensure when starting a job from configuration, SELF codes from the settings are applied automatically
  • Works under *PGMR auth on the user profile (e.g. not *ALLOBJ) - scott to test

@ajshedivy ajshedivy requested a review from worksofliam March 11, 2024 20:37
@worksofliam worksofliam requested a review from forstie March 11, 2024 21:04
@github-actions
Copy link

github-actions bot commented Mar 11, 2024

👋 A new build is available for this PR based on daaa1cc.

@github-actions
Copy link

github-actions bot commented Mar 11, 2024

👋 A new build is available for this PR based on 597d0c6.

worksofliam
worksofliam requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small bits. Looks good so far. I will update your todo list with a couple more items that I want to tackle here.

@worksofliam worksofliam linked an issue Mar 12, 2024 that may be closed by this pull request
Feature: Self Codes #137
Closed
15 tasks
worksofliam
worksofliam reviewed Mar 12, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Mar 12, 2024

👋 A new build is available for this PR based on ad0e371.

@github-actions
Copy link

github-actions bot commented Mar 12, 2024

👋 A new build is available for this PR based on a4ffe1d.

@github-actions
Copy link

github-actions bot commented Mar 18, 2024

👋 A new build is available for this PR based on 18494c3.

worksofliam
worksofliam reviewed Mar 18, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Mar 18, 2024

👋 A new build is available for this PR based on d75bb35.

@github-actions
Copy link

github-actions bot commented Mar 18, 2024

👋 A new build is available for this PR based on 17f8a47.

@github-actions
Copy link

github-actions bot commented Mar 18, 2024

👋 A new build is available for this PR based on c6c53f9.

worksofliam
worksofliam reviewed Mar 18, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Mar 19, 2024

👋 A new build is available for this PR based on 30d9459.

@github-actions
Copy link

github-actions bot commented Mar 19, 2024

👋 A new build is available for this PR based on 7d9b7a3.

@github-actions
Copy link

github-actions bot commented Mar 19, 2024

👋 A new build is available for this PR based on 7c9aaa9.

@github-actions
Copy link

github-actions bot commented Mar 20, 2024

👋 A new build is available for this PR based on 055cf03.

@github-actions
Copy link

github-actions bot commented Mar 21, 2024

👋 A new build is available for this PR based on 4287ffa.

@worksofliam worksofliam marked this pull request as ready for review March 21, 2024 17:51
@github-actions
Copy link

github-actions bot commented Mar 21, 2024

👋 A new build is available for this PR based on 0e65d27.

@github-actions
Copy link

github-actions bot commented Mar 22, 2024

👋 A new build is available for this PR based on fc6d945.

worksofliam
worksofliam approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have worked with Scott and he is happy. I have done a final code review, fixed some minor things, and it's looking sharp. Let's merge.

@worksofliam worksofliam merged commit 1aaec65 into main Mar 22, 2024
@forstie
Copy link
Collaborator

forstie commented Mar 26, 2024

Thanks for all the revisions.
Finally, SELF is coming center stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@worksofliam worksofliam worksofliam approved these changes

@forstie forstie Awaiting requested review from forstie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Self Codes

4 participants

@ajshedivy @forstie @worksofliam