Skip to content

Conversation

@worksofliam
Copy link
Member

@worksofliam worksofliam commented Mar 11, 2024

  • Adds content assist for named parameters when inside a prodedure or function
  • Adds signiture provider for procedures and functions

Todo:

  • Ensure that delimited names work correctly
  • Fix bug where parameters were missing from content assist due to index
Click me
create schema somelongonesareoktouseonceinawhile for schema somelong1s;
create procedure somelongonesareoktouseonceinawhile.somelongonesareoktouseonceinawhilehasprocedures();
drop procedure  if exists somelongonesareoktouseonceinawhile.
  somelongonesareoktouseonceinawhilehasprocedures;

create procedure somelongonesareoktouseonceinawhile.
  somelongonesareoktouseonceinawhilehasprocedures (somelongonesareoktouseonceinawhileparm1 integer) program name procedure1
  begin end;
create procedure somelongonesareoktouseonceinawhile.
  somelongonesareoktouseonceinawhilehasprocedures (somelongonesareoktouseonceinawhileparm2 integer, somelongonesareoktouseonceinawhileparm3 integer) program name procedure3
  begin end;
create procedure somelongonesareoktouseonceinawhile.
  somelongonesareoktouseonceinawhilehasprocedures (somelongonesareoktouseonceinawhileparm1 integer, somelongonesareoktouseonceinawhileparm5 integer, p3 bigint)
   program name procedure3
  begin end;
CALL somelongonesareoktouseonceinawhile.somelongonesareoktouseonceinawhilehasprocedures();


create schema "somelongonesareoktouse" for schema "somefun1";
create function "somelongonesareoktouse".
  "somelongonesareoktouseonceinawhilehasfuncs" ("somelongonesareoktouseonceinawhileparm1" integer) 
  returns integer 
  return 1;
create function "somelongonesareoktouse".
  "somelongonesareoktouseonceinawhilehasfuncs" ("somelongonesareoktouseonceinawhileparm1" date) 
  returns integer 
  return 1;

values "somelongonesareoktouse".();
values "somelongonesareoktouse"."somelongonesareoktouseonceinawhilehasfuncs"();

@github-actions
Copy link

👋 A new build is available for this PR based on 0db65b2.

@worksofliam worksofliam linked an issue Mar 11, 2024 that may be closed by this pull request
Signed-off-by: worksofliam <[email protected]>
@github-actions
Copy link

👋 A new build is available for this PR based on c1f23da.

@worksofliam worksofliam marked this pull request as ready for review March 11, 2024 21:06
@github-actions
Copy link

👋 A new build is available for this PR based on 149470a.

@github-actions
Copy link

👋 A new build is available for this PR based on 0fce84d.

@worksofliam worksofliam marked this pull request as draft March 12, 2024 15:26
@github-actions
Copy link

👋 A new build is available for this PR based on fa6a2f1.

@github-actions
Copy link

👋 A new build is available for this PR based on 5766c05.

@github-actions
Copy link

👋 A new build is available for this PR based on 4aaf931.

@worksofliam worksofliam marked this pull request as ready for review March 19, 2024 02:05
@github-actions
Copy link

👋 A new build is available for this PR based on 27ceb55.

@worksofliam worksofliam self-assigned this Mar 19, 2024
@github-actions
Copy link

👋 A new build is available for this PR based on 97bdb78.

@worksofliam worksofliam added the ready The tag should be taken off if it is being worked on, or if a review fails label Mar 22, 2024
@worksofliam worksofliam removed their assignment Mar 22, 2024
@github-actions
Copy link

👋 A new build is available for this PR based on 4bc6701.

@github-actions
Copy link

👋 A new build is available for this PR based on b1c9a61.

@forstie
Copy link
Collaborator

forstie commented Mar 26, 2024

Comments shared in slack.

Copy link
Collaborator

@forstie forstie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments left in slack

@github-actions
Copy link

👋 A new build is available for this PR based on 19549d6.

@github-actions
Copy link

👋 A new build is available for this PR based on dd6a19a.

@forstie
Copy link
Collaborator

forstie commented Mar 27, 2024

comments provided via slack

@github-actions
Copy link

👋 A new build is available for this PR based on 14943af.

@github-actions
Copy link

👋 A new build is available for this PR based on 44c2044.

@github-actions
Copy link

👋 A new build is available for this PR based on 35a5780.

@github-actions
Copy link

👋 A new build is available for this PR based on e31c24b.

@forstie
Copy link
Collaborator

forstie commented Mar 27, 2024

This has passed my quality checks. Thanks!

@worksofliam worksofliam merged commit d4e78c6 into main Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready The tag should be taken off if it is being worked on, or if a review fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parameter suggestions

4 participants