Skip to content

Conversation

@sebjulliand
Copy link
Member

The Cancel button in the editor title was not turned off when a query ended in error.
This PR turns the Cancel button off regardless of the query's end status.

How to test

  • Run a query that crashes: select * from nothing
  • The cancel button must be turned off
  • Run a query that is successful: 'select * from qsys2.netstat_info'
  • The cancel button must be turned off as well

@sebjulliand sebjulliand added the bug Something isn't working label Mar 18, 2024
@worksofliam worksofliam self-assigned this Mar 18, 2024
Signed-off-by: Seb Julliand <[email protected]>
@sebjulliand sebjulliand requested a review from davecharron March 18, 2024 16:45
Copy link
Collaborator

@davecharron davecharron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this issue.

@davecharron davecharron merged commit 0ed15a5 into codefori:main Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants