Skip to content

List query history by date #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 26, 2024
Merged

List query history by date #212

merged 7 commits into from
Mar 26, 2024

Conversation

@worksofliam
Copy link
Member

@worksofliam worksofliam commented Mar 20, 2024 •
edited
Loading

  • Change how we store history internally (no longer a list of strings)
  • Group statements by simple period (past day, past week, past month, later)
  • All but first are collapsed by default

warning: if you test this PR, it will break your existing query history

@github-actions
Copy link

github-actions bot commented Mar 20, 2024

👋 A new build is available for this PR based on 088f4a7.

@worksofliam worksofliam changed the title Add work to list query history by date List query history by date Mar 20, 2024
@github-actions
Copy link

github-actions bot commented Mar 20, 2024

👋 A new build is available for this PR based on a8558fd.

@davecharron
Copy link
Collaborator

davecharron commented Mar 20, 2024

Should we consider generic group captions as the dates become more removed from the present? Something like what is done in Outlook, for example.
image

@worksofliam worksofliam self-assigned this Mar 20, 2024
@worksofliam
Copy link
Member Author

worksofliam commented Mar 20, 2024

@davecharron I will work on that.

@github-actions
Copy link

github-actions bot commented Mar 21, 2024

👋 A new build is available for this PR based on 5ec9020.

@worksofliam worksofliam added the ready The tag should be taken off if it is being worked on, or if a review fails label Mar 22, 2024
@worksofliam worksofliam removed their assignment Mar 22, 2024
davecharron
davecharron requested changes Mar 22, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Mar 22, 2024

👋 A new build is available for this PR based on e549eab.

@worksofliam worksofliam requested a review from davecharron March 22, 2024 19:36
davecharron
davecharron requested changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@davecharron davecharron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this order

@worksofliam worksofliam removed the ready The tag should be taken off if it is being worked on, or if a review fails label Mar 22, 2024
@worksofliam worksofliam self-assigned this Mar 22, 2024
@github-actions
Copy link

github-actions bot commented Mar 25, 2024

👋 A new build is available for this PR based on b4651b2.

@worksofliam worksofliam requested a review from davecharron March 25, 2024 17:17
@worksofliam worksofliam added the ready The tag should be taken off if it is being worked on, or if a review fails label Mar 25, 2024
@github-actions
Copy link

github-actions bot commented Mar 25, 2024

👋 A new build is available for this PR based on 521737b.

@davecharron
Copy link
Collaborator

davecharron commented Mar 25, 2024 •
edited
Loading

If a query from a category other than Past day is run, it gets added to the Past day category, but does not always get removed from the previous category. I'll step through the failing case to see what the deal is.

@davecharron
Copy link
Collaborator

davecharron commented Mar 25, 2024

If a query from a category other than Past day is run, it gets added to the Past day category, but does not always get removed from the previous category. I'll step through the failing case to see what the deal is.

Looks like it's a weirdness where the statement ended up in two categories. Not sure how, but could be related to the warning on this PR that testing it breaks existing history. After manually deleting one of the instances, it behaves as expected.

@davecharron davecharron added the enhancement New feature or request label Mar 25, 2024
@worksofliam worksofliam merged commit ad2f9d1 into main Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davecharron davecharron davecharron approved these changes

@ajshedivy ajshedivy Awaiting requested review from ajshedivy

Assignees

@worksofliam worksofliam

Labels

enhancement New feature or request ready The tag should be taken off if it is being worked on, or if a review fails

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@worksofliam @davecharron