Fix resultSet view not grabing focus after reconnection #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seb Julliand <[email protected]>
davecharron
approved these changes
Mar 25, 2024
Collaborator
davecharron
left a comment
davecharron
left a comment
There was a problem hiding this comment.
Changes look reasonable, seems to work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue causing the ResultSet view to not grab the focus when running a statement after disconnecting and reconnecting to an IBM i.
This was caused by the
ResultSetPanelProvidernot keeping track of thedisposedstatus of the webview, preventing theensureActivationfrom working properly.By resetting the reference to the resolved webview once it's disposed, the
ensureActivationmethod can work as expected after reconnecting to a system.How to test
Without this PR, step
7.doesn't happen and the user must manually reveal the result set webview.