Add footer to results table so status is always visible #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 A new build is available for this PR based on 102be11. |
worksofliam
requested changes
Mar 25, 2024
Member
worksofliam
left a comment
worksofliam
left a comment
There was a problem hiding this comment.
Overall makes a lot of sense. I can see this new footer bar being used to also solve #102 down the line, since we have somewhere to put it now. See my comment about color and text. Other than that, it's decent.
|
👋 A new build is available for this PR based on 890803e. |
|
👋 A new build is available for this PR based on f33b579. |
worksofliam
approved these changes
Mar 25, 2024
Member
worksofliam
left a comment
worksofliam
left a comment
There was a problem hiding this comment.
This is a great change. A good setup for future features too
davecharron
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The results table view features a span that is updated with status, eg. statement running, row count...
The problem is that with a larger result set, the span remains out of view at the bottom until all rows have been retrieved and the result table scrolled to the end.
This PR fixes the issue by adding a footer to the table where the status is always displayed.