-
Notifications
You must be signed in to change notification settings - Fork 39
Feature/result table column headings #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/result table column headings #220
Conversation
|
@davecharron Send help! What am I doing wrong to test this? Sorry for the big screenshot, but it shows:
But can't get it to show up.
Through a little more digging, it looks like the server component isn't returning is still? "columns":[{"name":"EMPNO","type":"CHAR","display_size":6,"label":"EMPNO"}, |
You might try adding the LABEL ON COLUMN SAMPLE.employee (EMPNO TEXT IS 'Employee Number');https://www.ibm.com/docs/en/i/7.5?topic=statements-label
It's possible that you might need to reconnect after the LABEL ON. We've seen issues where SQ caches metadata so it doesn't always show recent changes. |
|
Okay, I got it working. It did require a new job to get the changes. This worked: select * from sample.employee;
LABEL ON COLUMN SAMPLE.employee (EMPNO IS 'Employee Number');More comments coming. |
|
@davecharron So based on this PR, I think we should change one of the JDBCOptions default. Perhaps, in the constructor(public options: JDBCOptions = {}) {
this.options["extended metadata"] = true;
} |
|
@worksofliam I'm not sure about changing the default. The Javadoc for JDBC Properties indicates a potential performance hit when "extended metadata" is set to true.
|
|
@davecharron Plus, users can store it in their custom config if they want it enabled always. Good point. |

Overview
Add support for customizing result column headings.
Column headingsNameandLabelNote:
Labelrequires the JDBC config 'Extended metadata' setting to be turned on.Test
Closes #127 Ability to toggle file column labels on results view