Fail on duplicate modules on the module path #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resolving the module path, no module id is allowed to exist multiple times. The location manager used to drop duplicates silently which led to hard to understand error messages when a plugin using plexus-java dropped a dependency without any notice. This change enforces uniqueness of module names on the module path and will add an exception to the PathResolveResult in that case.
|
@rfscholte plz review (I can't actually request a reviewer) |
|
I will close #164 once this PR has been merged |
|
I'm glad to see that we came to this solution. Technically it is probably not an illegal argument exception, but I can't think of a better solution and this might help to ensure module names are unique on the module path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving the module path, no module name is allowed to exist
multiple times.
The location manager used to drop duplicates silently which led to
hard to understand error messages when a plugin using plexus-java
dropped a dependency without any notice.
This change enforces uniqueness of module names on the module path
and will add an exception to the PathResolveResult in that case.