-
Notifications
You must be signed in to change notification settings - Fork 7
Prepare for publishing vie the Central Portal #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM, one remark: |
hehe - I have one, for mojohaus ... we can change also in mojohaus to have one configuration 😄 |
Yes, instead as before, when every project "invented" their own server.id (and I manage many), hence my settings.xml was full of copy pasta of different server.id with same auth 😄 So I started doing this: name the thing we use as it is (and as benefit, have one entry in settings for all, instead many copies of same) |
Also @slawekjaranowski see this: By using these 3 properties:
|
Co-authored-by: Tamas Cservenak <[email protected]>
0db671b
to
6facd7e
Compare
<njord.autoPublish>true</njord.autoPublish> | ||
<njord.publishingType>automatic</njord.publishingType> | ||
<njord.waitForStates>true</njord.waitForStates> | ||
<njord.enabled>false</njord.enabled> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cstamas What does that do? I thought that njord would only ever kick in if the distribution URI has scheme njord
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This completely disables Njord (by not creating njord session), and hence no njord component will ever "kick in", as all of them start by checking the session existence.
Release profile enables it:
https://github.com/codehaus-plexus/plexus-pom/blob/master/pom.xml#L821-L822
This just makes sure that in "normal" operations Njord is not meddling for sure, and even in case of release, it as you say, only does "local staging" and later publishing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure why was it done like it, as this really prevents Njord to stage snapshots for example, but that operation currently supports m-deploy-p as well, so no real need for Njord...
fix: #350