Skip to content

Conversation

slawekjaranowski
Copy link
Member

fix: #350

@slawekjaranowski slawekjaranowski marked this pull request as draft June 2, 2025 17:10
@cstamas
Copy link
Member

cstamas commented Jun 2, 2025

LGTM, one remark:
I'd name the server.id with longer (and more descriptive) name: sonatype-central-portal.

@slawekjaranowski
Copy link
Member Author

LGTM, one remark: I'd name the server.id with longer (and more descriptive) name: sonatype-central-portal.

hehe - I have one, for mojohaus ... we can change also in mojohaus to have one configuration 😄

@cstamas
Copy link
Member

cstamas commented Jun 2, 2025

Yes, instead as before, when every project "invented" their own server.id (and I manage many), hence my settings.xml was full of copy pasta of different server.id with same auth 😄

So I started doing this: name the thing we use as it is (and as benefit, have one entry in settings for all, instead many copies of same)

@cstamas
Copy link
Member

cstamas commented Jun 2, 2025

Also @slawekjaranowski see this:
maveniverse/njord#24 (comment)

By using these 3 properties:

  • no need to press Publish button
  • build will fail if validation fails
  • wait is few sec, as validation is quick

@slawekjaranowski slawekjaranowski marked this pull request as ready for review June 2, 2025 20:00
@slawekjaranowski slawekjaranowski merged commit 74c7fbd into master Jun 2, 2025
14 checks passed
@slawekjaranowski slawekjaranowski deleted the central-portal branch June 2, 2025 20:21
<njord.autoPublish>true</njord.autoPublish>
<njord.publishingType>automatic</njord.publishingType>
<njord.waitForStates>true</njord.waitForStates>
<njord.enabled>false</njord.enabled>
Copy link
Contributor

@kwin kwin Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cstamas What does that do? I thought that njord would only ever kick in if the distribution URI has scheme njord...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This completely disables Njord (by not creating njord session), and hence no njord component will ever "kick in", as all of them start by checking the session existence.

Release profile enables it:
https://github.com/codehaus-plexus/plexus-pom/blob/master/pom.xml#L821-L822

This just makes sure that in "normal" operations Njord is not meddling for sure, and even in case of release, it as you say, only does "local staging" and later publishing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure why was it done like it, as this really prevents Njord to stage snapshots for example, but that operation currently supports m-deploy-p as well, so no real need for Njord...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate publishing to central portal

4 participants