Skip to content

Conversation

@padmajabhol
Copy link
Member

Pull Request Template

Description

This PR moves all the content to the config/ folder and stores them in the form of js objects. We are moving all images to Cloudinary for better optimization and performance.

Fixes #164

@ikayz
Copy link
Contributor

ikayz commented Jun 20, 2022

@padmajabhol this is a WIP, so I can merge the current PR?

@padmajabhol
Copy link
Member Author

@padmajabhol this is a WIP, so I can merge the current PR?

I'll get this PR done by EOD. There are some pages that I haven't moved.

@ikayz
Copy link
Contributor

ikayz commented Jun 21, 2022

@padmajabhol reviewed, I've seen there is the config directory now. Are the assets in the assets directory going to be moved or you have a different plan for those?

@ikayz ikayz merged commit 6528c9d into codeisscience:gsoc22 Jun 21, 2022
Copy link
Contributor

@ikayz ikayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, reviewed and checked. Just a minor change to the footer year, it's been hard coded.

@padmajabhol
Copy link
Member Author

@padmajabhol reviewed, I've seen there is the config directory now. Are the assets in the assets directory going to be moved or you have a different plan for those?

They don't have to stay there, I will delete them as we go changing the code in each page.

@padmajabhol
Copy link
Member Author

Good to go, reviewed and checked. Just a minor change to the footer year, it's been hard coded.

My bad, I didn't notice, will change that.

@padmajabhol padmajabhol deleted the config branch June 24, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants