Skip to content

Conversation

LoganDark
Copy link

@LoganDark LoganDark commented Sep 27, 2024

right now the keyword completions are impossible to really change in any way, and it's super annoying, because we'd like to have autocomplete sections in our app, but if we put anything in any section, that section will placed below all the hundreds of keywords. we'd love to put the keywords in a section below the other far more important stuff

@marijnh
Copy link
Member

marijnh commented Sep 30, 2024

I think, rather than trying to make the package support all these options, it makes more sense to provide an option to disable keyword completion entirely, and have people who want something like this do that and use dialect.spec.keywords directly to build their own completion. Does that sound reasonable?

@LoganDark
Copy link
Author

I think that would be a lot more work for us. Generally we prefer adding options if something already does very nearly what we want, instead of cloning an entirely new implementation into our own codebase. We've already forked for this fix, so if there's any way to get something like this upstream, I'm all ears. Otherwise, this is the easiest and most time-effective solution for us right now.

@LoganDark LoganDark force-pushed the keyword-complete-options branch from 28163bc to efb1296 Compare September 30, 2024 15:01
marijnh added a commit that referenced this pull request Oct 1, 2024
FEATURE: The new `keywordCompletion` option can be used to define what kind of completions
are generated for keywords.

Issue #17
@marijnh
Copy link
Member

marijnh commented Oct 1, 2024

Does attached patch, which allows you to pass in a function that builds up the keyword completions, work for you?

@LoganDark
Copy link
Author

@marijnh yeah!

@marijnh
Copy link
Member

marijnh commented Oct 1, 2024

Great. I've tagged 6.8.0.

@marijnh marijnh closed this Oct 1, 2024
@LoganDark LoganDark deleted the keyword-complete-options branch October 1, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants