chore: implement xtermjs API #54
Open
+786
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make terminal.options public and mutable with Proxy interception - Make open() synchronous (WASM pre-loads in constructor) - Add windowsMode and allowProposedApi options for xterm.js compatibility - Add unicode.activeVersion property - Add onReady event that fires immediately for late subscribers - Implement event-based FitAddon auto-retry (no timers) - Add write queueing for data sent before WASM loads - Support runtime option changes (disableStdin, windowsMode, etc) - Fix: setupTerminal uses this.cols/rows instead of options.cols/rows Breaking changes: - open() is now synchronous (remove await keyword) - options is now public (was private) - WASM loading starts in constructor (slight startup cost) This enables true zero-friction migration from xterm.js - just change the import statement and all existing code works unchanged. Includes comprehensive test suite (18 xterm.js compatibility tests). Fixes resize issue where PTY was created before FitAddon could update terminal dimensions. Now term.cols/rows are used when creating WASM terminal, ensuring correct initial size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.