🤖 feat: update ghostty-web to next tag #642
Open
+99
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreya
force-pushed
the
update-ghostty
branch
from
f511699 to
2c5b3f1
Compare
- Track the next tag for ghostty-web to get latest development features - Upgrade @homebridge/node-pty-prebuilt-multiarch from 0.11.14 to 0.13.1 to get better Electron prebuild support Currently installs: - [email protected] - @homebridge/[email protected]
sreya
force-pushed
the
update-ghostty
branch
from
2c5b3f1 to
803a256
Compare
Add postinstall script that automatically downloads node-pty prebuilt binaries after bun install. This eliminates the manual step developers previously had to run. Why this is needed: - Bun blocks npm postinstall scripts by default for security - node-pty requires native .node binaries compiled for specific ABIs - Without prebuilds, terminals don't work in packaged Electron app How it works: - scripts/postinstall.sh runs after bun install (via Makefile) - Detects node or bun in PATH (with fallback to common locations) - Runs prebuild-install to download binaries from GitHub releases - Checks for build/Release/pty.node to verify success - Gracefully degrades if download fails (build continues) Benefits: - No manual steps for developers after git pull + bun install - Works with bun, node, or npm as package manager - Caches downloads in ~/.npm/_prebuilds for faster reinstalls - Clear error messages if manual intervention needed
Detect bundled prebuilds to avoid unnecessary downloads on Linux: - Linux: Prebuilds are bundled in npm package (prebuilds/linux-*) Script detects these and skips download entirely - macOS/Windows: No bundled prebuilds, downloads to build/Release/ Script downloads from GitHub releases as before Benefits: - Zero network calls on Linux VMs (instant postinstall) - Covers 15+ Node.js ABI versions for Linux out of box - Platform/arch detection matches node conventions (x86_64->x64, etc) - Clear messaging shows which path was taken This ensures remote Linux VMs running server mode aren't blocked by unnecessary downloads or network issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track the
nexttag for ghostty-web to automatically receive the latest development features, and upgrade node-pty to improve Electron compatibility.Changes:
^0.1.1→next(0.1.1-next.18.g98ed4f1)^0.11.14→^0.13.1The node-pty upgrade adds more Electron prebuilt binaries, though Electron 38 (ABI 139) is not yet available. The Node.js ABI version is downloaded and should work for basic terminal functionality.
Note: After
bun install, runnpm run installinnode_modules/@homebridge/node-pty-prebuilt-multiarchto ensure the prebuilt binaries are downloaded (bun blocks postinstall scripts by default).Generated with
mux